Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow photo refresh from the carousel #853

Closed
1 task
Tracked by #966 ...
teolemon opened this issue Jan 4, 2022 · 13 comments
Closed
1 task
Tracked by #966 ...

Allow photo refresh from the carousel #853

teolemon opened this issue Jan 4, 2022 · 13 comments
Labels
✏️ Contribution good first issue Good for newcomers help wanted Extra attention is needed 🎨 Mockups available Some mockups are available for this issue. Please check everything is ok before starting coding. 🎯 P1
Milestone

Comments

@teolemon
Copy link
Member

teolemon commented Jan 4, 2022

What

  • Allow photo refresh from the carousel

Part of

Mockup

retake photo (1)

@bhattabhi013
Copy link
Contributor

Hi @teolemon
I want to work on this. Can you please detail me about what needs to done?

As of now, I'm thinking about adding a reload/refresh button and on its click and I'll reload the images widget.

@teolemon
Copy link
Member Author

It's taking a new picture and uploading it to replace the existing one, not refreshing from server.

@alexgarel
Copy link
Member

I advocate implementing #1244 instead (it's also less invasive in the interface).

@teolemon
Copy link
Member Author

I advocate for this one. This is the way to actually get the data we need.

@stephanegigandet
Copy link
Contributor

I'm not advocating anything, but the proposed mockup is very confusing for users: unless you know that the first photo is supposed to be the front photo, the second is supposed to be the ingredients etc. it's very difficult to understand why there's a different button on each photo.

When we don't have a photo at all, there's a "Add an ingredients photo" (or similar) text that makes it obvious.

The solution proposed in #1244 would make things much more clear I think.

@teolemon
Copy link
Member Author

  • We need to do data refresh, and we need to do it hard and fast. Thus this solution which is easier to understand than scrolling left, including on a typically very wide photo of ingredients.
  • A grand total of 0 users is sliding left on the carousel to the "Add more interesting photos" button.

@alexgarel
Copy link
Member

Ok, but maybe we can do both ? (as told this scenario is not covering the case where there is no "ingredients" photo yet).

@monsieurtanuki
Copy link
Contributor

My comments:

  • how do you currently do that on the Android version?
  • I understand the need (expressed in this issue) of a fast-track action for picture refresh
  • I detect confusion around the purpose of each photo, because the fast-track mode doesn't do everything and is not verbose (that's because it's only a fast-track)

My suggestions:

  • keep the carousel of pictures of the OP but perhaps change the icon to a more standard Capture d’écran 2022-03-22 à 19 06 32 (or a custom combination of camera and refresh). For an end-user, the idea is to retake the picture (e.g. because it's blurred): the fact that it's going to be an additional picture for the same type (front, ingredients, ...) is not relevant for the user. And the camera icon means that we take a picture.
  • add a vertical banner to the right side (as a Stack child, always on top of the carousel), with a photo library icon Capture d’écran 2022-03-22 à 19 12 58 that would open a new "photo manager" page with detailed actions

@stephanegigandet
Copy link
Contributor

Frankly there is no way users will understand that the Camera icon (with a + or not) means that their photo will replace the selected photo. So we will end up with any photo being selected as anything.

The best solution is to have 1 single photo camera icon (e.g. on the top right corner) that opens the dialog to add more photos of a specific type. (in fact I remember it was proposed before).

If the aim is to have newer photos, then there are much more effective ways to convey that to users: just display a prompt in the product card "Our image of ingredients is a bit old, could you take a new one?", a bit like the robotoff prompts.

@stephanegigandet
Copy link
Contributor

Ok, but maybe we can do both ? (as told this scenario is not covering the case where there is no "ingredients" photo yet).

When there is no ingredient photo, there is a prompt to upload the photos of ingredients, and the text makes it very clear we want the photo of ingredients.

image

@teolemon teolemon added this to the V1 milestone Apr 27, 2022
@teolemon teolemon modified the milestones: V1, V1.1 Jun 18, 2022
@AshAman999
Copy link
Member

I think it was fixed in #3023
Can you have a look here @M123-dev

@M123-dev
Copy link
Member

M123-dev commented Sep 17, 2022

I guess the whole Gallery was a step in the right direction and I have to say I don't like the looks of a button on every image, but let's ask @teolemon what do you think is the Gallery when clicking on a image easy enouph

@teolemon
Copy link
Member Author

We can close it. I'm still annoyed by the usability of this carousel though, but we have more important topics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Contribution good first issue Good for newcomers help wanted Extra attention is needed 🎨 Mockups available Some mockups are available for this issue. Please check everything is ok before starting coding. 🎯 P1
Projects
Status: Done
Development

No branches or pull requests

7 participants