Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #1835 add modify photos btn #2079

Merged
merged 3 commits into from May 31, 2022
Merged

feat: #1835 add modify photos btn #2079

merged 3 commits into from May 31, 2022

Conversation

cli1005
Copy link
Contributor

@cli1005 cli1005 commented May 31, 2022

What

  • The Add or Refresh photo in Edit mode should open the full screen photo carousel to enable people to refresh photos

Screenshot

rpreplay-final1653490969_2KFl8WFj.mp4

Fixes bug(s)

Part of

@cli1005 cli1005 requested a review from a team as a code owner May 31, 2022 07:48
@teolemon teolemon added image upload ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users labels May 31, 2022
teolemon
teolemon approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but since there seems to be a few nice extra things in there, I'll defer to other for a more thorough review

@teolemon
Copy link
Member

@g123k does this look sound ?

@teolemon teolemon merged commit df88561 into openfoodfacts:develop May 31, 2022
@github-actions github-actions bot mentioned this pull request Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

Assignees

@cli1005 cli1005

Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users image upload
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Add or Refresh photo in Edit mode should open the full screen photo carousel (that will have edit buttons)
2 participants
@cli1005 @teolemon