Replace Flutter Intl plugin from localizely with new flutter internationalization #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanegigandet
requested review from
PrimaelQuemerais,
teolemon and
a team
There was a problem hiding this comment.
@stephanegigandet It looks OK to me.
My remarks:
- have you tried with 2 languages, just to be sure that the app shows the correct translated labels according to the phone's language?
- I think it is compatible with @teolemon's New Crowdin updates #13, though it looks like a tango step - we should merge this one first, then New Crowdin updates #13
I tried with English and French, it is working. |
Closed
1 task
|
ok to merge? (this repo is not set up to require approvals on PRs, but I think it would be a good idea not to merge PR before they are approved, as we do on the OFF server repo) |
teolemon
reviewed
Dec 27, 2020
| - source: /packages/smooth_app/lib/l10n/intl_en.arb | ||
| translation: /packages/smooth_app/lib/l10n/intl_%locale_with_underscore%.arb | ||
| - source: /packages/smooth_app/lib/l10n/app_en.arb | ||
| translation: /packages/smooth_app/lib/l10n/app_%two_letters_code%.arb |
There was a problem hiding this comment.
can we have proper locale support for
pt_PT, pt_BR, zh_CN, zh_TW…
There was a problem hiding this comment.
Flutter needs locales with just the language code, we can add "pt_BR", but "pt" has to be there:
flutter pub get
Arb file for a fallback, fr, does not exist, even though
the following locale(s) exist: [fr_FR].
When locales specify a script code or country code, a
base locale (without the script code or country code) should
exist as the fallback. Please create a {fileName}_fr.arb
file.
Generating synthetic localizations package has failed.
There was a problem hiding this comment.
Tested yesterday: #43 (comment)
teolemon
approved these changes
Dec 27, 2020
|
ok, good to merge |
|
merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @monsieurtanuki mentions, this is clearly not the simplest way to do things, but apparently it is the new recommended way (at least that's what is in the Flutter 1.22 announcement https://medium.com/flutter/announcing-flutter-1-22-44f146009e5f#f2cb and the Flutter internationalization guide: https://docs.google.com/document/d/10e0saTfAv32OZLRmONy866vnaw0I2jwL8zukykpgWBc/edit# )
I removed all the mostly empty .arb files from CrowdIn, once we have a more stable version of the app, we can upload app_en.arb to CrowdIn to get new translations for the actual strings we will need. At this time the app is so much in flux that it's probably not worth having anything translated yet.
Fixes #45 and #43