Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Null check operator used on a null value on Line 46 using null traverse operator #4700

Closed
wants to merge 2 commits into from

Conversation

harhitosw
Copy link

@harhitosw harhitosw commented Oct 6, 2023

Resolving

TypeError: Null check operator used on a null value File "camera_scan_page.dart", line 46, in CameraScannerPageState.didChangeDependencies

What

  • Null check operator was being used on the Null value in line 46 in camera_scan_page.dart (in set state ) used the Null traverse operator to fix the issue

Fixes bug(s)

@harhitosw harhitosw requested a review from a team as a code owner October 6, 2023 06:14
@github-actions github-actions bot added the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Oct 6, 2023
@monsieurtanuki monsieurtanuki changed the title Resolved Issue _TypeError: Null check operator used on a null value on Line 46 using null traverse operator fix: Null check operator used on a null value on Line 46 using null traverse operator Oct 6, 2023
@monsieurtanuki
Copy link
Contributor

Hi @harhitosw, and thank you for your PR!

Some advices:

  • in this project you're supposed to start your PR name with tags like fix: or feat: . If you don't you get an error. I've edited your PR
  • in the PR description after "Fixes: " you're supposed to put the issue number, e.g. #1111: when the PR is merged the issue will be automatically closed
  • you created this PR in your develop branch, which is not something I would recommend at all (especially given my low level in github)

Your code is good, but I would feel much better if you started a brand new PR from a specific branch, with a correct PR name, and a correct PR comment. (my main concern here being about using a specific branch).
Would you please do that?

@harhitosw
Copy link
Author

Hi @harhitosw, and thank you for your PR!

Some advices:

  • in this project you're supposed to start your PR name with tags like fix: or feat: . If you don't you get an error. I've edited your PR
  • in the PR description after "Fixes: " you're supposed to put the issue number, e.g. #1111: when the PR is merged the issue will be automatically closed
  • you created this PR in your develop branch, which is not something I would recommend at all (especially given my low level in github)

Your code is good, but I would feel much better if you started a brand new PR from a specific branch, with a correct PR name, and a correct PR comment. (my main concern here being about using a specific branch). Would you please do that?

Hello @monsieurtanuki thank you for pointing out and I will take care of the above facts hereafter . Also just for my information do I need to create a new separate branch in the fork , than make changes and create the pull request or do I need to use some existing branch for the changes and make the PR ?

@monsieurtanuki
Copy link
Contributor

@harhitosw Just create a brand new branch from scratch. I would suggest a name like fix/4696.

@harhitosw
Copy link
Author

harhitosw commented Oct 7, 2023

@harhitosw Just create a brand new branch from scratch. I would suggest a name like fix/4696.

Hello @monsieurtanuki I will create a new branch and also a new pull request maybe after that we can close this PR .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Projects
None yet
2 participants