fix: 5217 - no check on cookie as it's always null

[monsieurtanuki]

What

• Recent changes rely on a cookie field being populated.
• Unfortunately, that field is not populated by OpenFoodAPIClient.login2
• As a consequence, when returning to the app, the fact that cookie was null erased all local user configuration.

Fixes bug(s)

• Fixes: I am getting disconnected as soon as I close the app #5217

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 8.68%. Comparing base (4d9c7fc) to head (81ad603).
Report is 100 commits behind head on develop.

Files	Patch %	Lines
..._app/lib/data_models/user_management_provider.dart	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #5222      +/-   ##
==========================================
- Coverage     9.54%   8.68%   -0.87%     
==========================================
  Files          325     327       +2     
  Lines        16411   16575     +164     
==========================================
- Hits          1567    1440     -127     
- Misses       14844   15135     +291     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[teolemon]

So now, we'll have both, right ?

[monsieurtanuki]

@teolemon So now even if the cookie field is not populated, as it was the case on your device or mine, that won't reset your local credentials.
How come the cookie returned by login2 is null I don't know, probably worth investigating (in a new off-dart issue), but I assume the most urgent matter was not having to reconnect, UX-wise.