Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deep links are broken #5285

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented May 24, 2024

Hi everyone,

All deep links don't work anymore in the app.
In the Flutter doc, here is the statement:

If you use a third-party plugin, such as [uni_links](https://pub.dev/packages/uni_links), setting this property breaks the third-party plugin

In our case, the Crowdin plugin uses it. As the integration of Crowdin in the app is really temporary, I have forked the repo to remove any reference to uni_links.
(FYI They use this plugin for OAuth with Crowdin, which is not our use case)

@g123k g123k requested a review from a team as a code owner May 24, 2024 10:20
@g123k g123k changed the title fix: Deep links not working fix: Deep links are broken May 24, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.17%. Comparing base (4d9c7fc) to head (6a45e85).
Report is 132 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5285      +/-   ##
==========================================
- Coverage     9.54%   8.17%   -1.38%     
==========================================
  Files          325     356      +31     
  Lines        16411   17954    +1543     
==========================================
- Hits          1567    1468      -99     
- Misses       14844   16486    +1642     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit 84b68a3 into openfoodfacts:develop May 24, 2024
7 checks passed
@g123k g123k deleted the deep_links_fix branch May 27, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants