Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded padding from Welcome card which helps remove the overflow on tiny screens #662

Merged
merged 35 commits into from Nov 16, 2021
Merged

Remove unneeded padding from Welcome card which helps remove the overflow on tiny screens #662

merged 35 commits into from Nov 16, 2021

Conversation

jasmeet0817
Copy link
Contributor

Large screen:

Screenshot_1636997585

Tiniest screen I could simulate:

Screenshot_1636997565

slava-sh and others added 30 commits October 29, 2021 10:50
@slava-sh
Reuse summary card as scan card
5c4f815
Minor changes
ca59975
Formatting fix
308feb1
Remove unused imports
a4be0af
Create a separate file for ScanCard
fffd378
Format
17e6cdf
Formatting
f48e785
Rename product_page_helper -> product_card_helper
c75c5f0
Organize sort
a8258e4
@jasmeet0817
Merge branch 'openfoodfacts:develop' into main
a132e53
Dynamically limit the number of elements rendered on Scan card.
996bf5d
Minor fixes
4e7428d
Standardize summary card
75fde2e
Test changes
03753fa
Temp changes, remove later
9e32738
Clip Summary card when it overflows
b773e19
Format
60a75a1
@jasmeet0817
Merge branch 'openfoodfacts:develop' into main
0c7326c
Revert "Update localization for refs/heads/gha-l10n version"
c271b90 
This reverts commit d50b416.
Merge remote-tracking branch 'mine/main'
058fc9f
@jasmeet0817
Merge branch 'openfoodfacts:develop' into main
a983b6c
Merge remote-tracking branch 'mine/main'
b85f7fe
Update buttons on scan page as per the spec
7eb49a5
Update buttons on scan page as per the spec
fa59490
Update buttons on scan page as per the spec
771bef5
Update buttons on scan page as per the spec
70b693c
Adjust the scanner to be placed symmetrically in the center of button…
a82aedc 
…s and carousel
Adjust the scanner to be placed symmetrically in the center of button…
88bbb66 
…s and carousel
revert pub_upgrade's weird changes
8ba7bd9
Remove unneeded padding from Welcome card which helps remove the over…
93a5c7a 
…flow on tiny screens
@jasmeet0817 jasmeet0817 mentioned this pull request Nov 15, 2021
Closed
42 tasks
@teolemon teolemon added 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… scanning labels Nov 16, 2021
@jasmeet0817 jasmeet0817 merged commit c8f8ec9 into openfoodfacts:develop Nov 16, 2021
@jasmeet0817 jasmeet0817 deleted the main branch January 12, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev Awaiting requested review from M123-dev

Assignees
No one assigned
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jasmeet0817 @teolemon @slava-sh