Sync rendering of KnowledgePanels with the latest API changes. #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 tasks
|
Some CI warnings @jasmeet0817 |
Fixed |
monsieurtanuki
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
Hi @jasmeet0817!
I haven't seen anything strange; please have a look at my single comment though.
Comment on lines
19
to
31
| if (knowledgePanel.titleElement!.type == TitleElementType.GRADE) { | ||
| return ScoreCard( | ||
| iconUrl: knowledgePanel.titleElement.iconUrl!, | ||
| description: knowledgePanel.titleElement.title, | ||
| cardEvaluation: getCardEvaluationFromKnowledgePanel(knowledgePanel), | ||
| iconUrl: knowledgePanel.titleElement!.iconUrl!, | ||
| description: knowledgePanel.titleElement!.title, | ||
| cardEvaluation: getCardEvaluationFromKnowledgePanelTitleElement( | ||
| knowledgePanel.titleElement!, | ||
| ), | ||
| ); | ||
| } | ||
| return KnowledgePanelTitleCard( | ||
| knowledgePanelTitleElement: knowledgePanel.titleElement, | ||
| knowledgePanelTitleElement: knowledgePanel.titleElement!, | ||
| evaluation: knowledgePanel.evaluation, | ||
| ); |
There was a problem hiding this comment.
A switch syntax would be cleaner, as you're using an enum as input.
added 2 commits
November 18, 2021 11:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how it looks: