Per review , Simplify creation of Voucher

We now check against known type to instanciate the correct voucher instead of using a case
openfoodfoundation · Jul 18, 2023 · 7e2b104 · 7e2b104
1 parent f399686
commit 7e2b104
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/app/controllers/admin/vouchers_controller.rb b/app/controllers/admin/vouchers_controller.rb
@@ -9,13 +9,11 @@ def new
     end
 
     def create
-      case params[:voucher][:voucher_type]
-      when "Vouchers::FlatRate"
-        @voucher =
-          Vouchers::FlatRate.create(permitted_resource_params.merge(enterprise: @enterprise))
-      when "Vouchers::PercentageRate"
-        @voucher =
-          Vouchers::PercentageRate.create(permitted_resource_params.merge(enterprise: @enterprise))
+      voucher_type = params[:voucher][:voucher_type]
+      if Voucher::TYPES.include?(voucher_type)
+        @voucher = voucher_type.constantize.create(
+          permitted_resource_params.merge(enterprise: @enterprise)
+        )
       else
         @voucher.errors.add(:type)
         return render_error