Fix linter errors

openfoodfoundation · Aug 22, 2023 · 9d7dec7 · 9d7dec7
1 parent 285b41d
commit 9d7dec7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/app/services/order_cycle_distributed_products.rb b/app/services/order_cycle_distributed_products.rb
@@ -15,7 +15,12 @@ def products_relation
 
   def products_taxons_relation
     Spree::Product.where(id: stocked_products).
-      joins("LEFT JOIN (SELECT DISTINCT ON(product_id) id, product_id, primary_taxon_id FROM spree_variants) first_variant ON spree_products.id = first_variant.product_id").
+      joins(
+        "LEFT JOIN
+           (SELECT DISTINCT ON(product_id) id, product_id, primary_taxon_id FROM spree_variants)
+           first_variant
+         ON spree_products.id = first_variant.product_id"
+      ).
       select("spree_products.*, first_variant.primary_taxon_id").
       group("spree_products.id, first_variant.primary_taxon_id")
   end

diff --git a/spec/controllers/api/v0/products_controller_spec.rb b/spec/controllers/api/v0/products_controller_spec.rb
@@ -34,7 +34,8 @@
 
     it "gets a single product" do
       product.create_image!(attachment: image("thinking-cat.jpg"))
-      product.variants.create!(unit_value: "1", unit_description: "thing", price: 1, primary_taxon: taxon)
+      product.variants.create!(unit_value: "1", unit_description: "thing", price: 1,
+                               primary_taxon: taxon)
       product.variants.first.images.create!(attachment: image("thinking-cat.jpg"))
       product.set_property("spree", "rocks")
 
@@ -253,7 +254,8 @@
       end
 
       it "filters results by product category" do
-        api_get :bulk_products, { page: 1, per_page: 15, q: { variants_primary_taxon_id_eq: taxon.id } },
+        api_get :bulk_products,
+                { page: 1, per_page: 15, q: { variants_primary_taxon_id_eq: taxon.id } },
                 format: :json
         expect(returned_product_ids).to eq [product3.id, product2.id]
       end