Replace unless with conditional assignment

openfoodfoundation · Mar 2, 2020 · d81cbd4 · d81cbd4
1 parent 9647317
commit d81cbd4
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/lib/open_food_network/orders_and_fulfillments_report.rb b/lib/open_food_network/orders_and_fulfillments_report.rb
@@ -82,8 +82,7 @@ def scale_factor(product)
     end
 
     def order_permissions
-      return @order_permissions unless @order_permissions.nil?
-      @order_permissions = ::Permissions::Order.new(@user)
+      @order_permissions ||= ::Permissions::Order.new(@user)
     end
 
     def report_line_items