Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all managed instances to "Fully Enabled" split_checkout toggle #10658

Closed
RachL opened this issue Apr 4, 2023 · 3 comments · Fixed by #10693
Closed

Move all managed instances to "Fully Enabled" split_checkout toggle #10658

RachL opened this issue Apr 4, 2023 · 3 comments · Fixed by #10693
Assignees

Comments

@RachL
Copy link
Contributor

RachL commented Apr 4, 2023

Description

- As a: shopper
- On page: /checkout
- I want to be able to do: Only split checkout if I purchase an order on an instance managed by OFN global

Acceptance Criteria & Tests

Split_checkout must be fully enabled or targeting 100% of actors on:

  • NZ
  • ES
  • IE
  • HU
  • BE
  • DE
  • FR
  • UK
  • US
  • AU
  • CA
@dacook
Copy link
Member

dacook commented Apr 11, 2023

Hi, I'm not sure what has been discussed already, but if we want to fully enable split_checkout, why don't we remove the feature toggle altogether? Is it because we still want the old method as a backup? Or to continue supporting it for non-managed instances?

If we want to keep the toggle but enable for all instances, why don't we trust the instance managers to set that up?

In any case, it seems that we should start planning to remove the old method, and post an end-of-life notice about it with a date.

Sorry if this has already been answered elsewhere.

@RachL
Copy link
Contributor Author

RachL commented Apr 12, 2023

@dacook yes we've discussed it in delivery circle. the first plan was to go straight to #10636 but then someone suggested we do this issue first.

If we trust instance manager to do it, in 6 months this will still not be done and we are blocking vouchers and white label releases as well, so we need to drive this forward ourselves.

post an end-of-life notice about it with a date

Instance managers are already aware this is happening. The previous end-of-life communicated was 21st of March. So as soon as we are progressing this issue I can give them another date.

@dacook
Copy link
Member

dacook commented Apr 13, 2023

Thanks Rachel. If it helps unblock other work quickly, then I think a migration to fully enable the toggle is a good idea 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment