Activate split_checkout feature by default

[jibees]

What? Why?

• Closes Move all managed instances to "Fully Enabled" split_checkout toggle #10658

What should we test?

• As admin, visit /admin/feature-toggle/features deactivate or delete split_checkout feature
• Deploy PR
• Check that after deployment, feature split_checkout exists and is activate

Release notes

Changelog Category: User facing changes

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

[mkllnk]

Nice, very simple.

Long-term, I was wondering if we should expand our current list of features with two more lists. We could have:

1. current features with descriptions
2. active features
3. retired features

Then we always enable the active features and delete the retired features. Devs can then just move those feature names around. But the big downside would be that we enable the feature whenever the server is restarted even if we deactivated it again because there was a problem.

Another idea would be to have a rake task which can be triggered with ofn-install for all instances. That seems much better to me to control the timing or repeat it if necessary. Anyway, migrations are an easy way as well and don't require any additional work for now.

[rioug]

Shouldn't you be updating this file as well https://github.com/openfoodfoundation/openfoodnetwork/blob/master/lib/open_food_network/feature_toggle.rb ?

[jibees]

Shouldn't you be updating this file as well https://github.com/openfoodfoundation/openfoodnetwork/blob/master/lib/open_food_network/feature_toggle.rb ?

You mean, by changing the description of the feature for example? Or anything else?

[rioug]

I meant by moving it to RETIRED_FEATURE, but I realize now that I am jumping the gun, ignore me.

[drummer83]

Hi @jibees,
As proposed by you I disabled split checkout in the feature toggles and verified that it is switched off:

After staging the PR the flipper is activated automatically again and I see the split checkout:

I can still disable the feature manually and use the legacy checkout.

I have also tried deleting the flipper and re-staged the PR. This still showed the legacy checkout:

So I switched from UK to AU and immediately deleted the flipper (while split checkout was active). This brought back the legacy checkout:

Then I staged the PR and this brought split checkout back and activated automatically.

I think this is ready to go but leaving for you to decide and merge.
Thanks!

[jibees]

I have also tried deleting the flipper and re-staged the PR. This still showed the legacy checkout:

Yes, because migration has already been executed: that's why when you switch to AU (instead of UK) the migration can run, and then the split_checkout feature is activated.
So, to me, it's good.