Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Products with zero value in weight/volume field jam the BOM page #1202

Closed
sstead opened this issue Oct 28, 2016 · 5 comments
Closed

Products with zero value in weight/volume field jam the BOM page #1202

sstead opened this issue Oct 28, 2016 · 5 comments
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.

Comments

@sstead
Copy link

sstead commented Oct 28, 2016

Description

In "bulk order management", if I set up a weight/volume to 0, the system doesn't manage to update the price to 0 (inconsistency) and when I try save, it save "fields in red contains error" (it's in orange, not red ;-)). Also I modified another field properly (but weight to 1000g instead of 2000) and this second field was also in orange (confusing as we think there is a mistake).

Expected Behavior

Three options:
1- either if I try to type 0, price modify accordingly to 0, and when I click off the field a pop-in error message appear "You can't have items with zero quantity. Please delete the item if you want to cancel this product."
2- either if I try to type 0, price modify accordingly to 0, and I can save without problem, the order appear with a 0 value and price on the product. IMO that is "polluting information" and shouldn't happen, so I don't support that solution.
3- either if I try to type 0, price modify accordingly to 0, I can modify other fields, nothing happens when I click off BUT when I save the error message display "fields in red contain errors" and only the 0 one field is in red. IMO it is not clear enough as we don't say the reason of the error, so I think we need a pop-in, and UX would be better if done when I click off, so I can't possible save a quantity with 0.

My preference goes to 1, do you agree @sstead @enricostano ? If yes I will clean up that introduction post to make it very clear.

Actual Behavior

See Description above.

Steps to Reproduce

  1. Go to "orders", sub menu "bulk order management". Make sure with button "column" that the columns weight/volume and price are displayed.
  2. Try to reduce the quantity to 0 for one product. Change it for another one. See what happens with prices.
    3.Try to save, see what happen. Fix the 0 quantity by putting some number, try to save again. That should work.

Animated Gif/Screenshot

https://www.useloom.com/share/e7cc5956b8c04a88a18ce11c75b9582b

Previous images from Sally:
image

In products, I am allowed to edit an item and give it a weight/volume value of zero...
image

Severity

S4, as I guess not so many user want to put a product with a 0 quantity. Bug was identified by Sally but not reported by a user.

Your Environment

  • Version used: 1.10.1
  • Browser name and version: Version 64.0.3282.167 (Official Build) (64-bit)
  • Operating System and version (desktop or mobile): Ubuntu 16.04 LTS

Possible Fix

?

@Matt-Yorkley
Copy link
Contributor

I'll take a look at this now. I would think that a product should be able to have no weight/volume, but I'll have a look through the spec files to see if they suggest otherwise.

@Matt-Yorkley
Copy link
Contributor

I'm looking at the BOM interface now, and it allows the user to alter the weight/volume:

screenshot from 2016-11-27 18-53-27
screenshot from 2016-11-27 18-53-31

I'm logged in as a superuser, not sure if that makes a difference. Changing the weight/volume changes the price of the order as well, so if a product with weight 2 is set to 1, it becomes half the price. This doesn't really make sense as the product in the example is a bottle of juice...

@Matt-Yorkley
Copy link
Contributor

Matt-Yorkley commented Nov 27, 2016

I'm not even sure that weight/volume column is providing any useful information, as the number is normally tied to a type (weight/volume/items), a unit scale (ie 0.001) which acts as a modifier, and a unit name that explains the unit. The value only makes sense after it's processed with the other values, and is a bit meaningless out of context. So for instance "6" could translate to "6 muffins", "0.6kg bag" or "60cl bottle", depending on the other variables.

I'd be tempted to remove the column from the table altogether, but I'm not sure if there's any use cases where it would be needed...? @NickWeir63 @sstead ?

@sstead
Copy link
Author

sstead commented Nov 30, 2016

Hi @Matt-Yorkley , the ability to edit the weight/volume field of products is an important functionality for people selling things like legs of lamb, or watermelons. They might sell it at an approximate weight of 3kg, but then after they've boxed up the specific order, they can update it to the actual weight of 3.2kg and recalculate the price accordingly. The issue here is more relating to why the system gets all jammed up if a product has a weight/volume of zero, and if people should be able to make 0kg products? If it's something like tickets to an event/workshop, they can list the product as an item (no problem). What other need is there for 0kg/0L products?

@sigmundpetersen sigmundpetersen removed this from the Backlog milestone Oct 23, 2017
@myriamboure myriamboure added bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. and removed bug labels Feb 28, 2018
@openfoodfoundation openfoodfoundation deleted a comment from NickWeir63 Feb 28, 2018
@openfoodfoundation openfoodfoundation deleted a comment from sstead Feb 28, 2018
@lin-d-hop
Copy link
Contributor

No comments since 2016. Closing
#gitcull2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.
Projects
None yet
Development

No branches or pull requests

5 participants