Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to turn the feature toggle on for all new users #12282

Closed
RachL opened this issue Mar 18, 2024 · 6 comments · Fixed by #12606
Closed

Allow to turn the feature toggle on for all new users #12282

RachL opened this issue Mar 18, 2024 · 6 comments · Fixed by #12606
Assignees

Comments

@RachL
Copy link
Contributor

RachL commented Mar 18, 2024

Description

- As a: enterprise user newly created
- On page: /admin
- I want to be able to do: see admin_v3_style as default behavior

To do so, we need to be able to add this group of users to the feature toggle.

new users = created after July 3rd.

Acceptance Criteria & Tests

  1. Turn on feature toggle for new users
  2. Create an new enterprise
  3. See the new admin is here by default
  4. Check old enterprise have not changed
  5. Check disabling this group of actors brings back the old designs.

Dependencies

This can be done once we've implemented all BUU1 features, plus

@RachL RachL changed the title Allow to the feature toggle on for all new users Allow to turn the feature toggle on for all new users Mar 18, 2024
@mkllnk
Copy link
Member

mkllnk commented Apr 9, 2024

@RachL, from which date on do you want to count new users? Were you imagining the date of deployment? Or the time the feature is toggled on?

The easiest implementation would be to create a Flipper group which would select all users created after a certain date. That would allow you to enable or disable the feature for the entire group at any time, and still enable for individual users as well.

@RachL
Copy link
Contributor Author

RachL commented Apr 9, 2024

@mkllnk I assumed each instance could toggle it on or off when they want so yes the flipper group sounds perfect! But we need to define a date and I guess it will be hard coded in the group. So this is block until we know when the first milestone will be done 👍

@RachL RachL added the blocked label Apr 9, 2024
@dacook
Copy link
Member

dacook commented May 20, 2024

I'm not familiar with Flipper groups, but am estimating it won't take more than 1 day.

@dacook
Copy link
Member

dacook commented Jun 3, 2024

@RachL I've added a dependencies title in the description above, please let me know if this is not correct.

@RachL
Copy link
Contributor Author

RachL commented Jun 3, 2024

@dacook I don't know. This is mainly blocked because we need to choose a date, after which we consider people are new to the system. To be able to choose this date, we need to understand when the milestone will be ready. In my mind, we would be able to work on this issue in parallel of finishing the test: both could go on the release at the same time.

@RachL RachL removed the blocked label Jun 18, 2024
@RachL
Copy link
Contributor Author

RachL commented Jun 18, 2024

@dacook to avoid having someone registering and being switch on the new UI within a couple of days, I have added to the issue the date of July 3rd, which is the day after the release is deployed. Looks like a good target date 🤞 Will communicate this to IM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants