[BUU] Enable admin_style_v3 for new users from 3/07/2024 #12606
Conversation
dacook
added
the
user facing changes
| it "doesn't activate new product screen for old users" do | ||
| Timecop.freeze Time.zone.parse("2024-07-02") do | ||
| user_old = create(:user) | ||
|
|
||
| expect { | ||
| subject.up | ||
| }.not_to change { | ||
| OpenFoodNetwork::FeatureToggle.enabled?(:admin_style_v3, user_old) | ||
| } | ||
| end | ||
| end |
There was a problem hiding this comment.
This doesn't quite capture the case of old users still not being activated in the future. So if the logic wasn't based on the creation date but on the current date then we wouldn't catch that.
I would have structured the test like this:
- Create user for the past.
- Create user for the future.
- Test that one is disabled and the other enabled at the same time.
But I've seen the code. This is simple enough. 👍
| Flipper.register(:admins) { |actor| actor.respond_to?(:admin?) && actor.admin? } | ||
| # Groups | ||
| Flipper.register(:admins) do |actor| | ||
| actor.respond_to?(:admin?) && actor.admin? |
There was a problem hiding this comment.
In another PR, shall we simplify this?
| actor.respond_to?(:admin?) && actor.admin? | |
| actor.try(:admin?) |
There was a problem hiding this comment.
Good idea. This code is straight from the Flipper documentation. I'm guessing they chose that format to make it clear that an actor is not guaranteed to be a certain type of object.
|
Do we need to follow up with someone for the documentation update ? |
|
All good, Rachel confirms this is taken care of by instance managers (https://openfoodnetwork.slack.com/archives/C01CXQNJ1J6/p1719286230825269?thread_ts=1719239630.576049&cid=C01CXQNJ1J6) |
What? Why?
What should we test?
This is hard to test on staging, so I have done a dev test.
1. Migration
2. User created before 3rd July:
3. User created on 3rd July:
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
It's not strictly a dependency, but now that we are phasing the new design in, the test suite should be using the new design asap:
Documentation updates
Uh.. yeah everything? 😕
I think the old screenshots will be ok, but will look dated and it would be good to refresh them sometime.
More importantly, the Bulk Products screen will be different. I could only find one page in the guide for this: