Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "ready for" info from shipping method description area at checkout #12395

Closed
RachL opened this issue Apr 17, 2024 · 8 comments · Fixed by #12443
Closed

Remove "ready for" info from shipping method description area at checkout #12395

RachL opened this issue Apr 17, 2024 · 8 comments · Fixed by #12443
Assignees
Labels
good first issue papercut Labels papercuts after they've moved from the "Papercuts prioritized" column

Comments

@RachL
Copy link
Contributor

RachL commented Apr 17, 2024

Description

- As a: shopper
- On page: checkout/details
- I want to be able to do: sometimes, some shipping method are not available very day. It can raise a conflict with the content the shop manager puts in the "ready for" field.
Therefore, we should remove the display of the field in the shipping method description. It shall remain :

  • at the top of the checkout pages
  • on the dropdown of the shop
  • on order confirmation
  • on email confirmation

This is the area where we want to remove it:

image

Acceptance Criteria & Tests

  1. Set up a "ready for" information (=> delivery details at step 3 of the order cycle)
  2. See it shows up in the top right blue corner of the shopfront
  3. See it shows up on the top of the checkout process
  4. See order confirmation and email confirmation still have the info
  5. However, shipping method description in checkout/details does not have the info anymore
@RachL RachL added good first issue papercut Labels papercuts after they've moved from the "Papercuts prioritized" column labels Apr 17, 2024
@MrBowmanXD
Copy link
Contributor

Hello, i commented the code related to the distributor address panel, that makes the desired result but i receive two email confirmations, is it normal?

@RachL
Copy link
Contributor Author

RachL commented May 6, 2024

Hi @MrBowmanXD can you open a PR with your change? It might be easier for the team to give you a feedback this way :)

@MrBowmanXD
Copy link
Contributor

MrBowmanXD commented May 6, 2024

Have to check again, but a email confirmation with the name inserted on the form and a email confirmation with blank name were sent after the checkout process is complete. Tomorrow will try to reproduce this problem or check if it remains.

@MrBowmanXD
Copy link
Contributor

MrBowmanXD commented May 7, 2024

Now i understand the two emails. One is for the buyer the other for the shop owner. With that out of the way we can probably submit the pull request but i don't know if this feature (ready for info in shipping method description area at checkout/details), will be necessary for the future that's why i commented it and not delete.

@sigmundpetersen
Copy link
Contributor

Thank you @MrBowmanXD .
This PR is now ready for code review, let's wait for our devs to review it 👍

@MrBowmanXD
Copy link
Contributor

Will change the code in order to remove only the "ready for" section as noted by the reviewer.

@MrBowmanXD
Copy link
Contributor

MrBowmanXD commented May 8, 2024

Just made the commit with the changes necessary. Some checks failed will check after breakfast.

@MrBowmanXD
Copy link
Contributor

Indentation issues prevent from commits to pass the checks, will research this issue in order to see how to solve this problem.

filipefurtad0 added a commit that referenced this issue May 15, 2024
Remove "ready for" info from shipping method description area at checkout #12395 (solved)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue papercut Labels papercuts after they've moved from the "Papercuts prioritized" column
Projects
Status: Done
3 participants