-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate ResetPasswordConfirmation mail #1506
Translate ResetPasswordConfirmation mail #1506
Conversation
@daniellemoorhead ping you here, no emergency to be merged for Friday (great if it can of course!), @pacodelaluna made the "reset password" message translatable ;-) Thanks for that François! |
Hey there, assuming this also isn't linked to an issue? We've got a lot to get through for 1.8.9 so going to put this into 1.8.10 which should be out in the next couple of weeks. Cheers! |
It is linked to that issue @daniellemoorhead : #1039 |
Hey @myriamboure do you see the section above the comment box that shows which issue the issue the PR is linked to with a Disconnect button on the right? I'm not sure that this shows up for you, but it's where you link the issues so that they display together in Zenhub 😄 |
Interesting @daniellemoorhead ! I don't see it on Firefox (which I already use) but it shows up in Chrome ! I guess that also because Zenhub only works in Chrome... I guess I'll have to use Chrome for Github related work ;-) I link it now! |
So interesting, what works and what doesn't in each browser! I really wish all the zenhub features were part of github to make it easier for everyone 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, very good. I just commented on a little thing about the formatting. It would also be good to have test for this. Imagine we upgrade Spree and the mailer changes.
@@ -0,0 +1,5 @@ | |||
<%= t('.request_sent_text') %> | |||
<%= t('.link_text') %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared to the original file in the spree_auth_devise gem, there are some new lines missing.
I implemented my feedback in #1548. But since our user tester is not working today, I won't merge it. Are you happy with my changes? If yes, I schedule it for next Wednesday. Thank you. |
Merged in #1548. |
No description provided.