Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translations on Admin / Config / Content #3816

Open
Tracked by #3681
mkllnk opened this issue May 7, 2019 · 2 comments · Fixed by #7255
Open
Tracked by #3681

Missing translations on Admin / Config / Content #3816

mkllnk opened this issue May 7, 2019 · 2 comments · Fixed by #7255
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.

Comments

@mkllnk
Copy link
Member

mkllnk commented May 7, 2019

Description

As super admin you can visit Admin -> Configuration -> Content to change logos, footer and other text. On a fresh instance, these fields should contain defaults depending on the default language. Unfortunately, translations are not available in content defaults and missing translations are shown.

Expected Behavior

There is a default text in each field.

Actual Behaviour

There is a translation missing message in each field.

Steps to Reproduce

  1. Use a new instance or reset the database or use a database that didn't set all content fields. Delete the cache via rm tmp in the app directory if you reset the database.
  2. Log in as admin and go to Admin -> Configuration -> Content.

Animated Gif/Screenshot

Screenshot from 2019-05-07 16-11-56

Context

I tried to add a new content field and my dev environment showed these errors when testing.

Severity

s4 as it only affects super admins setting up a new instance.

Your Environment

  • Version used: 1.31.0

Possible Fix

Don't define ContentConfig in an initializer while I18n is not available. Create a service ContentConfig instead. If that doesn't help, re-implement the storage of content, not using Spree's preferences.

@sigmundpetersen sigmundpetersen added the bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. label May 7, 2019
@filipefurtad0 filipefurtad0 reopened this Apr 24, 2023
@RachL
Copy link
Contributor

RachL commented Apr 26, 2023

@sigmundpetersen @filipefurtad0 this issue is in dev, just checking it's the correct position?

@filipefurtad0
Copy link
Contributor

Hum, indeed thanks @RachL.
I don't think so - I guess this was automatically placed here after reopening the issue (there's nobody assiged). I'll move it to all the things 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.
Projects
Status: All the things 💤
Development

Successfully merging a pull request may close this issue.

4 participants