You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The OC pages have been broken in 3 steps but the OC object we are loading is still the same in the 3 steps.
The general settings page doesnt need any of the data about the variants in the exchanges. This takes a long time to load if there are a lot of variants already selected in the OC.
The Api::Admin::OrderCycleSerializer should always include exchanges. But Api::Admin::ExchangeSerializer#variants doesnt need to include the variants all the time:
in the General Settings page no data about variants is needed, so we could have a simple Exchange serializer as part of the OC serializer for this page.
likewise, in the Incoming Settings page we dont need to load all variants of the outgoing exchanges
luisramos0
changed the title
OC performance - use lightweight OC serializer when exchanges are not needed
OC performance - use lightweight OC serializer when exchanges are not needed (make general settings page fast)
Nov 22, 2019
sigmundpetersen
changed the title
OC performance - use lightweight OC serializer when exchanges are not needed (make general settings page fast)
Use lightweight OC serializer when exchanges are not needed (make general settings page fast)
May 29, 2024
What we should change and why (this is tech debt)
The OC pages have been broken in 3 steps but the OC object we are loading is still the same in the 3 steps.
The general settings page doesnt need any of the data about the variants in the exchanges. This takes a long time to load if there are a lot of variants already selected in the OC.
The Api::Admin::OrderCycleSerializer should always include exchanges. But Api::Admin::ExchangeSerializer#variants doesnt need to include the variants all the time:
Context
This comes from breaking the OC page in 3 separate steps.
Impact and timeline
This will make the general settings page faster as it should be even if the OC contains thousands of variants.
The text was updated successfully, but these errors were encountered: