Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backoffice New Order not working for specific user #4484

Closed
lin-d-hop opened this issue Nov 22, 2019 · 7 comments
Closed

Backoffice New Order not working for specific user #4484

lin-d-hop opened this issue Nov 22, 2019 · 7 comments
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround.

Comments

@lin-d-hop
Copy link
Contributor

lin-d-hop commented Nov 22, 2019

Description

A user is failing to be able to place an order through the backoffice.

The order is on an OC that is tagged and the customer has the matching tag. I am not sure if this is relevant but I know that other orders are successfully being placed through the backoffice.

Expected Behavior

For Hub: Cambridge Food Hub
Trying to place the following order:
1x ChariTea Green 24x330ml
1x ChariTea Black 24x330ml
1x ChariTea Red 24x330ml
1x ChariTea Mate 24x330ml

  • The £9.60 enterprise fee

The customer details are:
Info[at]charliescoffee.co
Name: Charlie's Coffee Company
Address: (shipping and billing)
44-45 Burleigh Street
Cambridge
CB1 1DJ

I have included a gif of the endless loop I end up in.

Actual Behaviour

There is no clear error message.

Steps to Reproduce

  1. I add items to the order. Then see that I need to add customer details to choose the shipping method.
  2. I add customer details.
  3. Then go back to the order and I can no longer see the list of items or the ability to add a shipping method.
  4. If I try to go to payment then I am told I haven't entered all the customer details and am taken to that screen.
  5. And then I am stuck in a loop.

Animated Gif/Screenshot

backendorder

Workaround

Haven't found one.

Severity

bug-s2 - or awaiting workaround. Removing tagging is not a suitable workaround for this user (I haven't tested if that works though will look on staging)

Your Environment

  • Version used: UK Prod 2.6.3
  • Browser name and version:
  • Operating System and version (desktop or mobile):

Possible Fix

@lin-d-hop lin-d-hop added the bug-s2 The bug is affecting any of the non-critical features described in S1 and there is no workaround. label Nov 22, 2019
@lin-d-hop lin-d-hop changed the title Backoffice Orders not working for specific user Backoffice New Order not working for specific user Nov 22, 2019
@luisramos0
Copy link
Contributor

Hello, I'll have a look now.

There's an hidden checkout workflow error that we are not showing to the user here:
"We are unable to ship the selected items to your shipping address. Please choose another shipping address."
I think this error would be shown to the user if this was a user checkout in the frontoffice.

I am investigating what is causing this error.

@luisramos0 luisramos0 self-assigned this Nov 25, 2019
@luisramos0
Copy link
Contributor

luisramos0 commented Nov 25, 2019

we are again (#4355) looking at "producer" overriding their own products.

what's causing the problem is that the "add variant to order" sees the correct inventory stock levels and lets user add variant to order BUT the checkout workflow is not "scoping" the variants and sees the stock in the catalog, not the inventory AND because the products are out of stock in the catalog, the checkout workflow fails...

I believe the quick workaround for this is to add stock to the products on the catalog, this will make checkout work AND will not break the stock logic: the quantity will still be taken from the inventory numbers...

This is a bug and the actual fix will be to scope variants during the checkout workflow process of creating what internally are called packages.

Is this still an S2 with the workaround @lin-d-hop ? I am not sure because it is quite a specific case.

reference:
products out of stock:
Screenshot 2019-11-25 at 13 31 31

inventory with stock:
Screenshot 2019-11-25 at 13 32 58

@lin-d-hop lin-d-hop added bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. and removed bug-s2 The bug is affecting any of the non-critical features described in S1 and there is no workaround. labels Nov 25, 2019
@lin-d-hop
Copy link
Contributor Author

To be tested after #4355 is fixed (which is the UKs next S3)

Thanks @luisramos0 I'll get this updated.

@luisramos0
Copy link
Contributor

I am not sure I was clear, I only mentioned 4355 because it is the same type of situation (overriding own products). This and 4355 require different fixes.

And now that I rethink this... this bug is not specific to "overriding own inventory", I havent tested but I think this will happen every time the product added is an override AND the producer stock is zero. It's a bit worse than initially described...

@lin-d-hop
Copy link
Contributor Author

Can we get rid of inventory yet?

@luisramos0
Copy link
Contributor

if you remove these from inventory you will bump into #4355

@RachL
Copy link
Contributor

RachL commented Aug 5, 2023

I don't think we will ever fix this one, but please reopen @lin-d-hop if you think otherwise

@RachL RachL closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround.
Projects
None yet
Development

No branches or pull requests

3 participants