-
-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update counts in OC edit page to exclude hidden overrides #4806
Comments
Hmm. trying to figure out an easy way out of this one... I thought I could make hidden variants visible but not editable. They would show up but be disabled and with a new tooltip: @Matt-Yorkley the code would be something like this: #5508 |
LGTM 👍 Does it work OK with the select all button? |
this needs product feedback, probably better to double check that @RachL @lin-d-hop and @kirstenalarsen dont see any issues with this decision: merge the two cases 1. visible only variant (user has no permissions to add to exchange) and 2. hidden variant (variant is marked as hidden in inventory) |
@luisramos0 just too be sure: the idea is that instead of not counting visible only variants and hidden variants, we would continue to count them but display them to the user as unselected and they would be able to select them but would have a tooltip to understand why. Is that correct? I think I like the logic because it saves time. User don't waste time in searching why there are missing variants. But I have 2 questions:
|
YES, with correction above (NOT). The checkbox is disabled in the screenshot.
It's complicated... this is the description in the code:
Select all would not select these, variants hidden in inventory and not-editable variants are not selectable. |
I echo the concern about large catalogues. In OFN Canada now users use the inventory tool either because (1) they made a mistake and thought the had to put their products there, or (2) they have a large catalogue and its easier to manage it in inventory - mostly because you can hide things from view. so we need to think about large product lists - I think yes, we need to solve it. |
thanks @tschumilas I am not sure I was clear about the definition of the problem. The problem is not generic, like large catalogs. The problem is about hidden variants in large catalogs. I think in practice we are talking about a user who is looking for a product in the shopfront with 100s of products. They cant find it there so they go to the OC edit page with those 100s of products to see what's going on. The natural process will be for the user to search for that product name in the exchange using the browser search? |
In Delivery train meeting we agreed this solution is not good enough because hiding variants is a feature user will want and with this we would be showing all the hidden variants. A new option was suggested: if there are hidden variants in the page, we keep the numbers broken but show a message like "there are hidden variants in your inventory". Or we can go back to "just fix the numbers" :-) |
For future reference, the problem is here: We get the list of eligible products in the exchange from the server and we count all variants of these products. To fix the numbers we need to either make the server remove the hidden variants from the payload or make a new process that removes the number of hidden variants from the total number. I investigated this a little bit now, maybe we could make the product serializer filter out hidden variants. I created a PR with that: #5656 I am leaving this issue for now. |
Description
Part of #4355
Counts shown in OC edit page include hidden overrides that cannot be added to the OC, resulting in confusing feedback.
See additional screenshots and notes here: #4355 (comment) and here: #4355 (comment)
Expected Behavior
Variant counts shown in the OC edit page should make sense.
Actual Behaviour
The numbers are misleading, eg: "4 of 2 Variants loaded".
Steps to Reproduce
Workaround
None.
Severity
bug-s4: it's annoying, but you can use it
The text was updated successfully, but these errors were encountered: