Confusing variants count in OC

[RachL]

Description

We have recently improved our count of variants, but there still are some weird cases.

Here is an example with french prod shop 173 :

1. The list of OC shows 65 variants:

2. The sum in incoming is correct.

3. In outgoing it says that I have selected 64 variants. When I unfold the list it says that it is showing me 65 out of 64 variants...

Steps to Reproduce

1. Go to /admin/order_cycles on French production
2. Have a look at OC 3063 for shop 173

Severity

bug-s3: a feature is broken but there is a workaround

Your Environment

• Version used: v2.7.8
• Browser name and version: Firefox 73
• Operating System and version (desktop or mobile): Desktop

[RachL]

Ok, because I'm a big cheater, I will use this one as an epic to group the issues on this currently in dev ready.

[luisramos0]

The problem described in this issue is not seen here any longer:
https://openfoodfrance.org/admin/order_cycles/3063/outgoing

Anyway, this epic's description looks like a duplicate of #4806 (one of the issues inside it).

[luisramos0]

@RachL fyi I have just fixed this problem

here in transifex (missing space):
https://www.transifex.com/open-food-foundation/open-food-network/translate/#fr/enyml/194011289?q=key%3Avariants_loaded

[RachL]

Anyway, this epic's description looks like a duplicate of #4806 (one of the issues inside it).

Yes I cheated a bit when creating the epic and forgot to update the description 😁

[luisramos0]

Adding feedback needed to make it clear this is blocked by the pending decision in #4806

[audez]

Hi! We have a hub manager that raised the problem (the fact that in step 3 the numbers didn't make sense, ex: 4 of 0 Variants Loaded)