Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mobile UX] Eur symbol displayed below the price of the item #6252

Closed
filipefurtad0 opened this issue Oct 26, 2020 · 4 comments · Fixed by #6383
Closed

[mobile UX] Eur symbol displayed below the price of the item #6252

filipefurtad0 opened this issue Oct 26, 2020 · 4 comments · Fixed by #6383
Assignees
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround.

Comments

@filipefurtad0
Copy link
Contributor

filipefurtad0 commented Oct 26, 2020

Description

In the shopfront and when using a mobile device, the Eur currency symbol is displayed below the price of the item. This is observed only for:
• mobile devices
• items with prices in EUR
• prices with 4 digits

See pic below.

Expected Behavior

Eur currently symbol should be displayed like this - i.e., after the price:
image.png

Actual Behaviour

Eur currently symbol is displayed like this - i.e., below the price:
image.png

Steps to Reproduce

  1. Got to Browserstack and choose a mobile device (tested for Android/iPhone Firefox/Chrome/Safari).
  2. Choose a shop with Eur currency and items with price which are at least 4 digits long
  3. Browse through the products and see the bug.

Animated Gif/Screenshot

Below, left side - staging-UK - pound currency is correctly displayed. Compare with pic on the right side staging-ES, Eur currency below the price (red arrows):

image

Workaround

Rotating your device 90°.

Severity

bug-s3: a feature is broken but there is a workaround

Your Environment

  • Version used: v3.3.0
  • Browser name and version: Firefox 81
  • Operating System and version (desktop or mobile): Mobile Android

Possible Fix

@filipefurtad0 filipefurtad0 added the bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. label Oct 26, 2020
@filipefurtad0 filipefurtad0 mentioned this issue Oct 26, 2020
8 tasks
@RachL
Copy link
Contributor

RachL commented Oct 26, 2020

@filipefurtad0 do you know if the position of the currency symbol is tested automatically ? I forgot but for example I think this bug might not appear in pound for example as the currency symbol is located before the amount.

@filipefurtad0
Copy link
Contributor Author

filipefurtad0 commented Oct 26, 2020

@RachL I don't know if this is tested automatically, I had a look at some specs but found nothing.

In any case, it should not appear in pound - this is what I wanted to show with the pic above... (left side, UK) Maybe I should add some text/green arrows to it, to make it more clear? I updated the description, hope it's clearer now 👍

@RachL
Copy link
Contributor

RachL commented Oct 26, 2020

no sorry it's on me @filipefurtad0 on my phone github wasn't showing me the left image 🤦

andrewpbrett added a commit to andrewpbrett/openfoodnetwork that referenced this issue Nov 16, 2020
@andrewpbrett
Copy link
Contributor

I was able to reproduce this by just changing the configuration to show the currency symbol after the amount (without changing to Euro, that is). Fix is on the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround.
Projects
None yet
3 participants