Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weight (per kg) Calculator not translated #774

Closed
marito59 opened this issue Jan 7, 2016 · 6 comments
Closed

Weight (per kg) Calculator not translated #774

marito59 opened this issue Jan 7, 2016 · 6 comments

Comments

@marito59
Copy link

marito59 commented Jan 7, 2016

The OpenFoodNetwork defined weight calculator string is not translated.

It seems that the string is hardcoded in app/models/open_food_network/calculator/weight.rb

How should we localise that string?

weight not translated

@myriamboure
Copy link
Contributor

@mkllnk more generally, we have some issues with the translations in the back office. Some are wrongly translated (like this one, there is a translation but it's not correct) and some are not translated, see example here:
non-translated-backoffice
I guess it's because the automatic translation from Spree works on strings that are originally from Spree, and all the things that have been customized for OFN are not automatically translated...
Anselm told me that @elf-pavlik and the Hackaton team had worked on that, so that the back office can be fully translatable. Am I right? How can we move forward on that? In France most hub managers won't speak English, so we need to be able to translate the back office as well.
Thanks :-)

@mkllnk
Copy link
Member

mkllnk commented Jan 12, 2016

Ok. The admin interface was not included in the initial internationalisation project. And it's right that the Hackathon team worked on it and made huge progress (#753). But they are not finished yet. Once they are done, we can merge it into our master branch and include it in the next release. Do you have a deadline for the internationalisation of the admin panel?

@myriamboure
Copy link
Contributor

You're right @mkllnk it was not in the first step of work in the internationalisation project, and as you say the hackaton people worked on it but there is still work to do. We are waiting for some feedbacl from Pavlik as he only just reached Mexico, to talk with him about the next steps. I'm not sure there is a define deadline, it's just that for the French first beta-testers, some of them are not so comfortable with English... So it's kind a priority for the French instance, and Nicolas (https://github.com/blancnic) proposed to work on it (could we add him as a contributor so that I can ping him?) but it needs some coordination with @elf-pavlik :-) I know @marito59 also has worked on it and says that not everything has been done at the hackaton on that matter (maybe you can share your inputs?)

@blancnic
Copy link
Contributor

I'm going to identify all translation issues in back-office and after I will contact @elf-pavlik to check.

@blancnic
Copy link
Contributor

@mkllnk I commented #753 too. Actually, it will be easier to me to continue to work on translation when you will add commits of the hackathon . Thanks!

@myriamboure
Copy link
Contributor

not relevant anymore will open other specific issue on calculator's options translation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants