Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message when saving product changes #8385

Closed
filipefurtad0 opened this issue Oct 20, 2021 · 9 comments
Closed

Error message when saving product changes #8385

filipefurtad0 opened this issue Oct 20, 2021 · 9 comments
Assignees
Labels
AU Selected to be done by the Australian active instance bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.

Comments

@filipefurtad0
Copy link
Contributor

filipefurtad0 commented Oct 20, 2021

Description

As reported here - When editing products on the /products page users are getting the message:
Saving failed. Save failed due to invalid data:undefined

Changes seem to be saved anyway, so this is confusing.

Expected Behavior

No error message should be seen.

Actual Behaviour

Saving failed. Save failed due to invalid data:undefined is displayed when saving a product (/products)

Steps to Reproduce

Not sure, it's reproducible but seems a bit erratic. Subsequent changes on the same product: sometimes the error is triggered, some times it is not...

  1. Go to the /products page
  2. Filter products by enterprise (not sure this is decisive for this bug)
  3. Change the name of a product. Click Save Changes
  4. Repeat till you see the error... -> obviously some detail is missing here. Not sure what could that be....

Animated Gif/Screenshot

This one would deserve the wtf label:

Peek 2021-10-20 16-57

image

Workaround

The user should ignore the error message.

Severity

bug-s4: it's annoying, but you can use it

Confusing to the users, and seems to have generated reports to support teams. Worth upgrading to s3?

Your Environment

  • Version used: v4.1.3
  • Browser name and version: Observed on Firefox, Chrome
  • Operating System and version (desktop or mobile): Linux and other OS

Possible Fix

@filipefurtad0 filipefurtad0 added the bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. label Oct 20, 2021
@adele-ofn
Copy link

Hi Filipe, thanks for logging this bug. Confirming that I've also replicated the bug in Chrome (MacOS Sierra 10.12.6):
Screen Shot 2021-10-21 at 9 55 45 am
Screen Shot 2021-10-21 at 9 56 07 am
Screen Shot 2021-10-21 at 9 56 30 am

@sinansonmez
Copy link
Contributor

Hi @filipefurtad0

I will try to do a deep dive for this issue

@filipefurtad0
Copy link
Contributor Author

filipefurtad0 commented Oct 25, 2021

Hey @sinansonmez 👋
Please feel free to do so.
It does seem tricky find the root cause, as it does not always happen. So, in case you get stuck, please to drop a line and move to another one 👍

@sinansonmez
Copy link
Contributor

sinansonmez commented Oct 25, 2021

Yeah @filipefurtad0 you are right it is kinda hard to reproduce it. I tried many times in my local, but no luck :( . I see that you reproduced this issue in staging environment. I will try couple more time tomorrow in my local to reproduce

@sinansonmez
Copy link
Contributor

Update from my side. Unfortunately, I couldn't reproduce the issue. I will look for sth else to work on it

@RonellaG RonellaG added the AU Selected to be done by the Australian active instance label Mar 1, 2022
@georgethoppil georgethoppil self-assigned this Apr 19, 2022
@georgethoppil
Copy link
Contributor

@filipefurtad0 I tried this a couple of times as well and I cannot reproduce. Can you see if you are able to achieve this now?

@filipefurtad0
Copy link
Contributor Author

Hey @georgethoppil ,
This was appearing in very unspecific circumstances... Indeed I can't reproduce it in my test setups.

@adele-ofn: can you still verify this bug in production?

@RachL
Copy link
Contributor

RachL commented Jul 21, 2022

As we cannot reproduce it for now. I'm closing this one :)

@RachL RachL closed this as completed Jul 21, 2022
@tschumilas
Copy link

I think I can reproduce this one (I've been editing thousands of products today to change some tax cagegories, and I think I see a pattern). I am finding that this error reliably presents when 2 conditions are met: (1) a product is deleted from the list and (2) a product is changed after that deletion. At least I think so... Just deleting a product does not give the error. Just changing a product doesn't seem to give the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AU Selected to be done by the Australian active instance bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.
Projects
None yet
Development

No branches or pull requests

7 participants