Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Customer endpoint improvements #9167

Closed
mkllnk opened this issue May 10, 2022 · 1 comment · Fixed by #9394
Closed

[API] Customer endpoint improvements #9167

mkllnk opened this issue May 10, 2022 · 1 comment · Fixed by #9394
Assignees
Labels
funded feature papercut Labels papercuts after they've moved from the "Papercuts prioritized" column

Comments

@mkllnk
Copy link
Member

mkllnk commented May 10, 2022

What is the problem we are solving

After publishing the customer endpoint behind a feature toggle we got some suggestions for improvements. I selected a few which would be good to do now before publishing the endpoint as stable.

Success factors = expected outcome

Region and country codes are useful IDs to compare across databases:

  • Replace region string with an object: region: { code: "VIC", name: "Victoria" }
  • Replace country with an object: country: { code: "AU", name: "Australia" }

Please note:

  • The country code should be the two-letter version.
  • The update action should also be changed to this new format. We best rely on the code to find the record but we can search for the name as well if the code is not present.
@lin-d-hop
Copy link
Contributor

Please track your hours on this in clockify under the Customer Endpoint funded feature.
Thanks!

@mkllnk mkllnk added the papercut Labels papercuts after they've moved from the "Papercuts prioritized" column label May 26, 2022
@apricot12 apricot12 self-assigned this May 26, 2022
@jibees jibees self-assigned this Jul 5, 2022
@jibees jibees added priority We focus on this issue right now and removed priority We focus on this issue right now labels Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
funded feature papercut Labels papercuts after they've moved from the "Papercuts prioritized" column
Projects
None yet
4 participants