-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply save bar to more admin pages #950
Comments
@oeoeaio can you just check whether or not this is an issue in your eyes.... Those are the only three things I picked up on, all else seemed to be working well! Thanks Bing! |
@bingxie do you think you could have a look at the second issue Sally found? I will I fix the first and third issues. If you can't find and easy way to do it, don't worry about it. It isn't a big deal. |
@oeoeaio I knew the second issue, for this form part of them are not ng-model, so we use the form onchange event to watch the dirty status. But this event is not triggered by the change on the text input until user click another place of the page. So I can not find an easy way to fix it. |
@sstead I just deployed this PR to staging2, if you have time could you please check the issue 1 & 3. |
Hi @bingxie issues 1 and 3 are fixed :) thanks! |
Hey there @bingxie, where are we at in fixing issue 2? |
@daniellemoorhead I reckon we won't fix it for now. |
@daniellemoorhead From my perspective, I can not find a easy way to fix the issue2. If we want to fix this issue, maybe we need to re-implement the form. |
Apply save bar to more admin pages:
The text was updated successfully, but these errors were encountered: