Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply save bar to more admin pages #950

Closed
bingxie opened this issue May 4, 2016 · 8 comments
Closed

Apply save bar to more admin pages #950

bingxie opened this issue May 4, 2016 · 8 comments
Assignees

Comments

@bingxie
Copy link
Contributor

bingxie commented May 4, 2016

Apply save bar to more admin pages:

  1. create order cycle
  2. bulk edit products
  3. edit enterprise
@sstead
Copy link

sstead commented Jun 1, 2016

@oeoeaio can you just check whether or not this is an issue in your eyes.... image

image

image

Those are the only three things I picked up on, all else seemed to be working well! Thanks Bing!

@oeoeaio
Copy link
Contributor

oeoeaio commented Jun 1, 2016

@bingxie do you think you could have a look at the second issue Sally found? I will I fix the first and third issues.

If you can't find and easy way to do it, don't worry about it. It isn't a big deal.

@bingxie
Copy link
Contributor Author

bingxie commented Jun 1, 2016

@oeoeaio I knew the second issue, for this form part of them are not ng-model, so we use the form onchange event to watch the dirty status. But this event is not triggered by the change on the text input until user click another place of the page. So I can not find an easy way to fix it.
Thanks for fixing the other two issues.

@bingxie
Copy link
Contributor Author

bingxie commented Jun 3, 2016

@sstead I just deployed this PR to staging2, if you have time could you please check the issue 1 & 3.

@sstead
Copy link

sstead commented Jun 3, 2016

Hi @bingxie issues 1 and 3 are fixed :) thanks!

@daniellemoorhead daniellemoorhead modified the milestones: v1.9 - Enigmatic Edamame!, v1.8.1 - Punkt Jun 8, 2016
@daniellemoorhead
Copy link
Contributor

Hey there @bingxie, where are we at in fixing issue 2?

@bingxie
Copy link
Contributor Author

bingxie commented Jun 8, 2016

@daniellemoorhead I reckon we won't fix it for now.

@bingxie
Copy link
Contributor Author

bingxie commented Jun 16, 2016

@daniellemoorhead From my perspective, I can not find a easy way to fix the issue2. If we want to fix this issue, maybe we need to re-implement the form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants