Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable invoices config only controls Print bulk action #10547

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

vviekk
Copy link
Contributor

@vviekk vviekk commented Mar 13, 2023

What? Why?

Enable invoice config only controls the visibility of "Print invoices" bulk action and the rest remain unaffected.

Modified the specs accordingly.

What should we test?

  • Check bulk order actions available with enable invoices enabled.
    • The following should be available:
      • print invoices
      • Cancel orders
      • Resend confirmations
  • With enable invoices disabled:
    • Cancel orders
    • Resend confirmations

Release notes

Changelog Category: User facing changes

Copy link
Contributor

@jibees jibees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is actually difficult to read, but the solution seems very simple.

Thanks for this one!

Copy link
Member

@abdellani abdellani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thank you @vviekk

@drummer83 drummer83 self-assigned this Mar 26, 2023
@drummer83 drummer83 added the pr-staged-au staging.openfoodnetwork.org.au label Mar 26, 2023
@drummer83
Copy link
Contributor

Hi @vviekk,
Thanks for this pull request. I had a look and here are my results!

BEFORE the PR

Invoice Setting Available for Super Admin Available for Admin
Enabled Resend confirmation, Send invoices, Print invoices, Cancel orders ✔️ Resend confirmation, Send invoices, Print invoices, Cancel orders ✔️
Disabled No bulk actions available ❌ No bulk actions available ❌

Invoices enabled

image

image

Invoices disabled

image

image

AFTER the PR

Invoice Setting Available for Super Admin Available for Admin
Enabled Resend confirmation, Send invoices, Print invoices, Cancel orders ✔️ Resend confirmation, Send invoices, Print invoices, Cancel orders ✔️
Disabled Resend confirmation, Cancel orders ✔️ Resend confirmation, Cancel orders ✔️

I have also checked that the available bulk actions are still working as expected. 👍

Invoices enabled

image

Invoices disabled

image

Summary

If invoices are disabled, we don't see the bulk actions around invoices anymore, but the other actions (resend confirmation and cancel orders) are still available. This is exactly what we wanted to see. Great work!!!
This one is ready to go! 🎉
Thank you so much!

@drummer83 drummer83 merged commit 4c61666 into openfoodfoundation:master Mar 26, 2023
@drummer83 drummer83 removed the pr-staged-au staging.openfoodnetwork.org.au label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Admin][Orders] All bulk actions are hidden if invoices are deactivated in the instance configuration
4 participants