Bump webpack-cli and webpack-dev-server from v3 to v4 #10568

dependabot · 2023-03-15T09:58:12Z

Bumps webpack-dev-server from 3.11.3 to 4.12.0.

Release notes

Sourced from webpack-dev-server's releases.

v4.12.0

4.12.0 (2023-03-14)

Features

allow to set the sockjs_url option (only sockjs) using the webSocketServer.options.sockjsUrl option (#4586) (69a2fba)

catch runtime error (#4605) (87a26cf)

improve styles for overlay (#4576) (791fb85)

open editor when clicking error on overlay (#4587) (efb2cec)

Bug Fixes

compatibility with experiments.buildHttp (#4585) (5b846cb)

respect NODE_PATH env variable (#4581) (b857e6f)

v4.11.1

4.11.1 (2022-09-19)

Bug Fixes

respect client.logging option for all logs (#4572) (375835c)

v4.11.0

4.11.0 (2022-09-07)

Features

make allowedHosts accept localhost subdomains by default (#4357) (0a33e6a)

Bug Fixes

auto reply to OPTIONS requests only when unhandled (#4559) (984af02), closes #4551

v4.10.1

4.10.1 (2022-08-29)

Bug Fixes

compatibility with old browsers (#4544) (6a430d4)

v4.10.0

4.10.0 (2022-08-10)

... (truncated)

Changelog

Sourced from webpack-dev-server's changelog.

4.12.0 (2023-03-14)

Features

allow to set the sockjs_url option (only sockjs) using the webSocketServer.options.sockjsUrl option (#4586) (69a2fba)

catch runtime error (#4605) (87a26cf)

improve styles for overlay (#4576) (791fb85)

open editor when clicking error on overlay (#4587) (efb2cec)

Bug Fixes

compatibility with experiments.buildHttp (#4585) (5b846cb)

respect NODE_PATH env variable (#4581) (b857e6f)

4.11.1 (2022-09-19)

Bug Fixes

respect client.logging option for all logs (#4572) (375835c)

4.11.0 (2022-09-07)

Features

make allowedHosts accept localhost subdomains by default (#4357) (0a33e6a)

Bug Fixes

auto reply to OPTIONS requests only when unhandled (#4559) (984af02), closes #4551

4.10.1 (2022-08-29)

Bug Fixes

compatibility with old browsers (#4544) (6a430d4)

4.10.0 (2022-08-10)

Features

allow to configure more client options via resource URL (#4274) (216e3cb)

... (truncated)

Commits

4ffcf2b chore(release): 4.12.0
a615d5b chore(deps): update (#4768)
87a26cf feat: catch runtime error (#4605)
b0f15ac chore(deps-dev): bump @babel/cli from 7.20.7 to 7.21.0 (#4745)
3edafc0 chore(deps): bump ws from 8.12.0 to 8.12.1 (#4737)
8afc916 chore(deps-dev): bump eslint-config-prettier from 8.6.0 to 8.7.0 (#4759)
ecb2cc5 chore(deps-dev): bump eslint from 8.34.0 to 8.35.0 (#4753)
becc95d chore(deps-dev): bump webpack from 5.75.0 to 5.76.0 (#4761)
7860017 chore(deps-dev): bump core-js from 3.28.0 to 3.29.0 (#4755)
8817fa8 chore(deps): bump open from 8.4.1 to 8.4.2 (#4748)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dacook · 2023-03-16T01:11:37Z

It doesn't work :(

$ yarn install
...
$ bin/webpack-dev-server
/Users/dcook/projects/openfoodnetwork/node_modules/webpack-cli/bin/utils/prompt-command.js:46
	return func(...args);
	       ^

TypeError: Class constructor ServeCommand cannot be invoked without 'new'
    at runWhenInstalled (/Users/dcook/projects/openfoodnetwork/node_modules/webpack-cli/bin/utils/prompt-command.js:46:9)
    at promptForInstallation (/Users/dcook/projects/openfoodnetwork/node_modules/webpack-cli/bin/utils/prompt-command.js:140:10)
    at /Users/dcook/projects/openfoodnetwork/node_modules/webpack-cli/bin/cli.js:32:43
    at Object.<anonymous> (/Users/dcook/projects/openfoodnetwork/node_modules/webpack-cli/bin/cli.js:366:3)

dacook · 2023-03-16T01:33:15Z

I think I solved it!
But I don't understand why Dependabot chose not to update webpack-cli earlier.

A month later, webpack-cli v5 was released, but I think we need to do that separately. I wonder if dependabot will open up a PR for that after this is merged..

What should a dev test?

yarn install
foreman start

dacook

Requires someone else to test on their dev environment.

mkllnk · 2023-03-20T04:46:09Z

Dev test failed. 🔴

The webpack-dev-server raises errors:

ERROR in chunk admin [entry]
js/[name]-[contenthash].js
Cannot use [chunkhash] or [contenthash] for chunk in 'js/[name]-[contenthash].js' (use [hash] instead)

ERROR in chunk admin-styles [entry]
css/admin-styles-fea4a876.css
Cannot use [chunkhash] or [contenthash] for chunk in 'js/[name]-[contenthash].js' (use [hash] instead)

ERROR in chunk admin-styles-v2 [entry]
css/admin-styles-v2-0313b166.css
Cannot use [chunkhash] or [contenthash] for chunk in 'js/[name]-[contenthash].js' (use [hash] instead)

ERROR in chunk application [entry]
js/[name]-[contenthash].js
Cannot use [chunkhash] or [contenthash] for chunk in 'js/[name]-[contenthash].js' (use [hash] instead)

ERROR in chunk darkswarm [entry]
css/darkswarm-4088a64b.css
Cannot use [chunkhash] or [contenthash] for chunk in 'js/[name]-[contenthash].js' (use [hash] instead)

ERROR in chunk mail [entry]
css/mail-783c5a38.css
Cannot use [chunkhash] or [contenthash] for chunk in 'js/[name]-[contenthash].js' (use [hash] instead)

I didn't see it at first because there is other output afterwards but then I tested the auto-reloading after changing CSS and it raised these errors again.

dependabot · 2023-03-20T09:59:09Z

A newer version of webpack-dev-server exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server) from 3.11.3 to 4.12.0. - [Release notes](https://github.com/webpack/webpack-dev-server/releases) - [Changelog](https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md) - [Commits](webpack/webpack-dev-server@v3.11.3...v4.12.0) --- updated-dependencies: - dependency-name: webpack-dev-server dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

I don't know why, but Dependabot decided not to: #9798 (comment) This is required for webpack-dev-server v4.

This now gets included as a dependency of webpack-cli v4. If webpack-cli had been upgraded earlier, we never would have needed to specify this.

Error was: ``` ERROR in chunk admin [entry] js/[name]-[contenthash].js Cannot use [chunkhash] or [contenthash] for chunk in 'js/[name]-[contenthash].js' (use [hash] instead) ```

jibees · 2023-03-20T10:35:50Z

I've commit a fix and rebased the branch. This one requires a strong deployment test I guess.

dacook · 2023-03-21T00:45:22Z

Great teamwork.
I just tested (note with updated Node since rebase) and can confirm that error no longer occurs.

The JS, CSS and add to cart all look good.

dacook · 2023-03-21T00:47:04Z

I will assume no-one has any other issues and go ahead and merge :)

jibees · 2023-03-21T13:03:22Z

@dacook just to know, did you test a deployment?

Edit:

Deployment of master is on its way: https://semaphoreci.com/openfoodfoundation/openfoodnetwork-2/servers/fr-staging/deploys/969
Passed! ✅
But I got a 500 on page /:

I checked bugsnag: https://app.bugsnag.com/open-food-france/coopcircuits/errors/6419ac4014b1a40009d5c567

gems/webpacker-5.4.4/lib/webpacker/manifest.rb:79:in `handle_missing_entry': Webpacker can't find logo-white-notext.png in /home/openfoodnetwork/apps/openfoodnetwork/releases-old/2023-03-21-130502/public/packs/manifest.json. Possible causes:
1. You want to set webpacker.yml value of compile to true for your environment
   unless you are using the `webpack -w` or the webpack-dev-server.
2. webpack has not yet re-run to reflect updates.
3. You have misconfigured Webpacker's config/webpacker.yml file.
4. Your webpack configuration is not creating a manifest.
Your manifest contains:
{
}
 (ActionView::Template::Error)
    from gems/webpacker-5.4.4/lib/webpacker/manifest.rb:49:in `lookup!'
    from gems/webpacker-5.4.4/lib/webpacker/helper.rb:193:in `rescue in resolve_path_to_image'
    from gems/webpacker-5.4.4/lib/webpacker/helper.rb:189:in `resolve_path_to_image'
    from config/initializers/webpack.rb:6:in `image_pack_path'
    from app/views/home/_tagline.html.haml:5:in `_app_views_home__tagline_html_haml__2572215756437575251_120080'

Logged on server, directory packs doesn't exist under /home/openfoodnetwork/apps/openfoodnetwork/releases-old/2023-03-21-130502/public

ls: cannot access '/home/openfoodnetwork/apps/openfoodnetwork/releases-old/2023-03-21-130502/public/packs': No such file or directory

Sounds like same as: rails assets:precompile does not create /public/packs directory rails/webpacker#1759

(partial) conclusion: Opening an issue, as it's not that simple...

dacook · 2023-03-21T22:53:43Z

@dacook just to know, did you test a deployment?

🤦 Oh no, sorry I didn't even though you made it very clear! I was thinking "development" test.. because it was affecting devDependencies only.

I don't understand how this could have affected deployment, but it seems like this update is the cause. Thanks so much for responding to this with a fix.

dependabot bot added dependencies javascript Pull requests that update Javascript code labels Mar 15, 2023

dacook self-requested a review March 16, 2023 00:51

dacook added the blocked label Mar 16, 2023

dacook changed the title ~~Bump webpack-dev-server from 3.11.3 to 4.12.0~~ Bump webpack-cli and webpack-dev-server from v3 to v4 Mar 16, 2023

dacook added dev-test A dev need to test this one and removed blocked labels Mar 16, 2023

dacook approved these changes Mar 16, 2023

View reviewed changes

dependabot bot and others added 4 commits March 20, 2023 11:33

Bump webpack-cli from 3.3.12 to 4.10.0

a97d416

I don't know why, but Dependabot decided not to: #9798 (comment) This is required for webpack-dev-server v4.

Remove @webpack-cli/serve

0632553

This now gets included as a dependency of webpack-cli v4. If webpack-cli had been upgraded earlier, we never would have needed to specify this.

Modify configuration to match new version of webpacker

bfbcdba

Error was: ``` ERROR in chunk admin [entry] js/[name]-[contenthash].js Cannot use [chunkhash] or [contenthash] for chunk in 'js/[name]-[contenthash].js' (use [hash] instead) ```

jibees force-pushed the dependabot/npm_and_yarn/webpack-dev-server-4.12.0 branch from de0ccda to bfbcdba Compare March 20, 2023 10:36

dacook merged commit 7ad5181 into master Mar 21, 2023

dacook deleted the dependabot/npm_and_yarn/webpack-dev-server-4.12.0 branch March 21, 2023 00:47

dacook self-assigned this Mar 21, 2023

jibees mentioned this pull request Mar 21, 2023

Deployment failed on master #10593

Closed

jibees mentioned this pull request Mar 29, 2023

Webpack, dev. env: Fix configuration export #10631

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump webpack-cli and webpack-dev-server from v3 to v4 #10568

Bump webpack-cli and webpack-dev-server from v3 to v4 #10568

dependabot bot commented on behalf of github Mar 15, 2023

dacook commented Mar 16, 2023

dacook commented Mar 16, 2023

dacook left a comment

mkllnk commented Mar 20, 2023

dependabot bot commented on behalf of github Mar 20, 2023

jibees commented Mar 20, 2023

dacook commented Mar 21, 2023

dacook commented Mar 21, 2023

jibees commented Mar 21, 2023 •

edited

dacook commented Mar 21, 2023

Bump webpack-cli and webpack-dev-server from v3 to v4 #10568

Bump webpack-cli and webpack-dev-server from v3 to v4 #10568

Conversation

dependabot bot commented on behalf of github Mar 15, 2023

v4.12.0

4.12.0 (2023-03-14)

Features

Bug Fixes

v4.11.1

4.11.1 (2022-09-19)

Bug Fixes

v4.11.0

4.11.0 (2022-09-07)

Features

Bug Fixes

v4.10.1

4.10.1 (2022-08-29)

Bug Fixes

v4.10.0

4.10.0 (2022-08-10)

4.12.0 (2023-03-14)

Features

Bug Fixes

4.11.1 (2022-09-19)

Bug Fixes

4.11.0 (2022-09-07)

Features

Bug Fixes

4.10.1 (2022-08-29)

Bug Fixes

4.10.0 (2022-08-10)

Features

dacook commented Mar 16, 2023

dacook commented Mar 16, 2023

What should a dev test?

dacook left a comment

Choose a reason for hiding this comment

mkllnk commented Mar 20, 2023

dependabot bot commented on behalf of github Mar 20, 2023

jibees commented Mar 20, 2023

dacook commented Mar 21, 2023

dacook commented Mar 21, 2023

jibees commented Mar 21, 2023 • edited

dacook commented Mar 21, 2023

jibees commented Mar 21, 2023 •

edited