[admin_v3] New brand colours in admin interface #10791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacook
force-pushed
the
10630-new-brand-colours
branch
from
1479bd4
to
b4a61a7
Compare
dacook
force-pushed
the
10630-new-brand-colours
branch
from
b4a61a7
to
d1c58b8
Compare
This seemed like a good separation which will probably help with the upcoming changes. Co-authored-by: jibees <jb.bellet@gmail.com>
Individual files may be copied in order to replace the old files. NOTE: these may need manually re-syncing. If any of the copied files have changed on master in the meantime, we'll need to manaully review to consider bringing those changes to the new design.
Note that mail.css is still referring to the old palette.
Aka 'Havelock Blue', which is going to be changing.
color-5 is used for error messages.
This also changes the orange to red, but that's part of the plan.
Some templates still had this colour hardcoded. They are using angular so I didn't spend time updating them.
> That way we only have one orangy/red colour and we start simplifying things.
dacook
changed the title
dacook
force-pushed
the
10630-new-brand-colours
branch
from
d1c58b8
to
14345ef
Compare
mkllnk
approved these changes
May 29, 2023
Comment on lines
-8
to
+9
| failure: {style: {color: '#da5354'}} | ||
| error: {style: {color: '#da5354'}} | ||
| failure: {style: {color: '#C85136'}} | ||
| error: {style: {color: '#C85136'}} |
There was a problem hiding this comment.
I wonder if we could define CSS variables... but probably not worth it at the moment. So this does change some colours even without the feature toggle on.
|
Hey @dacook , Thanks for the notes on what to test 馃檹
Before this PR After this PR After enabling Admin v3 styles
Before this PR After this PR After enabling Admin v3 styles
Before this PR After this PR After enabling Admin v3 styles
Noticed no change in functionality. Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Setting up a new feature-toggled stylesheet, and just getting started on BUU with some colour changes. As you can see, there is clearly more to do.
There are some minor changes of reds that will appear outside of feature toggle.
#C85136#C60F13In admin_v3, the error messages will need adjusting:
#008397Don't worry, we'll continue to work on the admin_v3 styles!!
What should we test?
Existing Admin interface
Error messages (eg invalid form input) and icons will have a slightly different red, but everything else should look the same. The warning icon styles have been refactored slightly, so
/admin/enterpriseAdmin v3 styles
/admin/feature-toggle/features/admin_style_v3Release notes
Changelog Category: User facing changes > 馃槑 Feature toggled
This does slightly change some warning colours for all users, but it doesn't seem worth announcing.
Dependencies
Documentation updates