chore(deps): bump foundation-sites from 5.5.2 to 5.5.3

[dacook]

Better 7 years late than never...

What? Why?

This partially resolves CWE-79: https://security.snyk.io/vuln/npm:foundation-sites:20150619

What should we test?

This is a minor update to the library used for styles on the shopfront (admin interface is not affected).
A quick look through the customer-facing frontend to see if there's regressions should be enough.

Release notes

Changelog Category: Technical changes

The title of the pull request will be included in the release notes.

[dacook]

I've noticed only one thing changed:

1. Font size on "update" button in Edit cart screen has increased.

Should be an easy fix.

[dacook]

Actually, it turns out it didn't fully resolve the vulnerability, so there's no point upgrading this for that reason.
It's 7 years old so I don't think there's any point upgrading for new features or further support, either.

So I suggest we don't bother with this.

[mkllnk]

Can we lock the version to 5.X.X?

[dacook]

Probably, but do you think we should do this update? (and any other highly unlikely updates to v5?)

[mkllnk]

Why not? It would remove the question of updating in the future if we are on the latest already. 😄

But as you say, it's unlikely that there will be more. So no big impact either way. But we may as well finish this and lock the version in and then nobody will question it again, I guess.

[dacook]

I'm unable to replicate the update cart button issue now, perhaps something just didn't load properly in my dev environment. Still, it would be good to have a manual test on a staging environment.

[filipefurtad0]

Hey @dacook,

Thanks for spotting that minor regression!

Indeed, I could reproduce it throughout Chrome/Firefox/Safari:

Before

After

Other than that, I've noticed no other changes whatsoever. So, merging.
And opening an issue, to fix the update button.