Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename 'new invoice' button to 'create or update invoice' #11354

Conversation

abdellani
Copy link
Member

What? Why?

What should we test?

Release notes

Changelog Category: User facing changes

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@abdellani abdellani self-assigned this Aug 8, 2023
@abdellani abdellani force-pushed the fix-rename-invoice-generate-update-button branch from f398b14 to ee9a9fa Compare August 8, 2023 09:16
@abdellani abdellani marked this pull request as ready for review August 8, 2023 09:24
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy.

@RachL RachL self-assigned this Aug 9, 2023
@RachL RachL added the pr-staged-fr staging.coopcircuits.fr label Aug 9, 2023
@RachL
Copy link
Contributor

RachL commented Aug 9, 2023

Working good! Got me thinking about other improvements, I will run them by Mario 👍 Merging!

@RachL RachL removed the pr-staged-fr staging.coopcircuits.fr label Aug 9, 2023
@RachL
Copy link
Contributor

RachL commented Aug 9, 2023

@abdellani some conflits to resolve first

@mkllnk mkllnk force-pushed the fix-rename-invoice-generate-update-button branch from ee9a9fa to 620dd70 Compare August 9, 2023 23:35
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflict resolved. Merging after tests passed.

@mkllnk mkllnk merged commit 926c8ae into openfoodfoundation:master Aug 9, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[invoices] Don't generate a new invoice if adjustments label changes
3 participants