[DFC API] Add custom OFN product id to DFC SuppliedProduct #11378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkllnk
added
no-staging-FR
| @@ -1,5 +1,6 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| require "data_food_consortium/connector/connector" | |||
There was a problem hiding this comment.
Suggested change
| require "data_food_consortium/connector/connector" | |
| require "datafoodconsortium/connector" |
There was a problem hiding this comment.
well, maybe not the best change :P will read better
1 task
mkllnk
changed the title
mkllnk
added
the
technical changes only
mkllnk
force-pushed
the
dfc-ofn-product-group-id
branch
2 times, most recently
from
4b349ac
to
5c33bab
Compare
When the application is not preloaded then running Rspec doesn't know Rails until the spec helper is loaded. So we can't use Rails to find the path of the spec helper. This has been fixed before but the DFC Address code was developed at the same time and missed.
The Spree::Variant in OFN corresponds to a DFC SuppliedProduct. But several Spree::Variant can be grouped under one Spree::Product which wasn't exposed on the DFC API. I'm adding a custom property here which can be used internally and shouldn't break any other DFC tools. A gotcha of this first test implementation: The `ofn:` prefix has not been defined in the context. Software needs to know that this is an Open Food Network attribute or ignore it. We could define our own context and ontology and publish it on our website but I don't see any benefit of that at this point.
mkllnk
force-pushed
the
dfc-ofn-product-group-id
branch
from
5c33bab
to
8b32ac2
Compare
mkllnk
force-pushed
the
dfc-ofn-product-group-id
branch
from
8b32ac2
to
02f251c
Compare
In Rswag request specs, the `response` block is like `describe` and is just used to group several other blocks. It can be long and that's okay.
|
@mkllnk I am assuming this need to be tracked agains : |
dacook
approved these changes
Sep 22, 2023
engines/dfc_provider/lib/data_food_consortium/connector/importer.rb
Outdated
Show resolved
Hide resolved
dacook
approved these changes
Sep 22, 2023
|
Merging as no manual test needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ This is a funded feature. Please track your time in
#9170 OFN DFC Products.What? Why?
The DFC doesn't model grouping of several products (variants). So we add an OFN custom property for our own integrations. Other software should ignore it. For other semantic web tools the
ofn:URI is not defined and can't be resolved. We haven't defined our own ontology. But I don't see a need for that at the moment.What should we test?
Release notes
Changelog Category: Technical changes
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates