Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump wicked_pdf from 2.6.3 to 2.7.0 #11447

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 24, 2023

Bumps wicked_pdf from 2.6.3 to 2.7.0.

Changelog

Sourced from wicked_pdf's changelog.

[2.7.0]

New Features

Fixes

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Aug 24, 2023
@mkllnk
Copy link
Member

mkllnk commented Aug 28, 2023

There are a few specs failing:

     Failure/Error: if running_in_development?
     
     ActionView::Template::Error:
       uninitialized constant Webpacker::VERSION
     
                 Webpacker::VERSION
                          ^^^^^^^^^
     # ./app/helpers/application_helper.rb:64:in `pdf_stylesheet_pack_tag'

Looks like an loading issue.

@filipefurtad0
Copy link
Contributor

@mkllnk,

I'm re-running the build... let's see.

I've read somewhere that wkhtmltopdf repo has been archived. This is probably not the reason for the failure, but we do use it and wickedpdf as well, which relies on it.

I'm not sure we won't need to replace these soon.

@sigmundpetersen
Copy link
Contributor

New Features

Support Shakapacker 7

Maybe this is related to the webpacker failure

@mkllnk
Copy link
Member

mkllnk commented Aug 29, 2023

I think that @sigmundpetersen is right and the failures come from this release and have nothing to do with wkhtmltopdf. Our options are:

  • Add a workaround by loading the missing constant.
  • Raise an issue with wicked_pdf.
  • Ignore this release and wait for them to fix it.

Since we don't need this release at the moment, I'm in favour of just closing this PR. But the ideal process would be searching for an existing issue, raising one if it doesn't exist and add a workaround in the meantime.

@mkllnk
Copy link
Member

mkllnk commented Aug 29, 2023

Since wkhtmltopdf was mentioned, I had a look at the project status. Yes, it's archived. The maintainer doesn't really see a future in it. Alternatives are:

But as long as this works for us, we don't need to change. Maybe wicked_pdf will choose another software at some point?

We just have to remember that we can only render sanitised input. If we allow stuff like script tags from users in reports or invoices then they can take control of our server because of the used libraries which are old and unsupported.

Bumps [wicked_pdf](https://github.com/mileszs/wicked_pdf) from 2.6.3 to 2.7.0.
- [Release notes](https://github.com/mileszs/wicked_pdf/releases)
- [Changelog](https://github.com/mileszs/wicked_pdf/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mileszs/wicked_pdf/commits)

---
updated-dependencies:
- dependency-name: wicked_pdf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@rioug rioug force-pushed the dependabot/bundler/wicked_pdf-2.7.0 branch from b90af78 to 0361355 Compare January 10, 2024 05:53
@rioug rioug self-assigned this Jan 10, 2024
@rioug
Copy link
Collaborator

rioug commented Jan 24, 2024

Open an issue here mileszs/wicked_pdf#1098

@rioug
Copy link
Collaborator

rioug commented Jan 29, 2024

PR has been accepted : mileszs/wicked_pdf#1099.

Closing this, we can upgrade when they release a version with the fix.

@rioug rioug closed this Jan 29, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 29, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/bundler/wicked_pdf-2.7.0 branch January 29, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants