Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev ENV only] Adds attribute to enterprise factory #11624

Conversation

filipefurtad0
Copy link
Contributor

...so that sample data rake task creates visible enterprises by default

What? Why?

We've had reports of new contributors struggling to have an open shop after running docker seed data; enterprises seem to be created as not visible by default, which is confusing to newcomers. This might be a side effect from this PR.

This PR changes this default behavior, so that seed data creates visible enterprises.

What should we test?

  • green build.
  • running the docker scripts should create a visible, open shop.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

so that sample data rake task creates visible enterprises by default
@filipefurtad0 filipefurtad0 added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Oct 4, 2023
@filipefurtad0 filipefurtad0 self-assigned this Oct 4, 2023
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, good pickup Filipe!

@dacook
Copy link
Member

dacook commented Oct 4, 2023

I just tested the ofn:sample_data rake task, and the shops all appear by default ✅

@dacook dacook merged commit ee13d10 into openfoodfoundation:master Oct 4, 2023
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants