Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix open Contact tab from "customers only" message #11789

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fix open Contact tab from "customers only" message #11789

merged 2 commits into from
Dec 19, 2023

Commits on Dec 15, 2023

  1. Add data-action=tabs-and-panels

    @duleorlovic
    duleorlovic committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    ba7ffc2 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. Use activate instead of changeActivePanel/ChangeActiveTab 

    Remove shop-tabs controllers since we can listen on `"data-action":
"orderCycleSelected@window->tabs-and-panels#activateDefaultPanel"`

Test for cases:
* activate by clicking on tab
* activateDefaultPanel on orderCycleSelected event
* activateFromWindowLocationOrDefaultPanelTarget to activate tab based
  on achor in URL
    @duleorlovic
    duleorlovic committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    120e299 View commit details
    Browse the repository at this point in the history