Fix mapping of flash messages on order cycle pages

[dacook]

What? Why?

While working on flash messages I noticed these could be tidied up.

I think lazy-lookup is the way to go for helping organise the locale file. However it does mean these strings might need re-translating. Does Transifex automatically copy duplicates for you? We shall see..

• part of Update success / notice / error messages with the correct status #11884

What should we test?

Test on the old design, or if #11874 has been merged, you can check the new admin_style_v3 design.
The success messages now appear as a success, not a 'notice'. (Green in the old design, black in the new)

• Order cycle create
• Order cycle update
• Order cycle clone
• Order cycle notify producers

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

[rioug]

Nice one 👍

[mkllnk]

Great!

[drummer83]

Hi @dacook,
That's a nice improvement. Thanks! 👍

Test results

Action	Before	After
Create
Update (Save and Next)
Clone
Notify producers	no confirmation	no confirmation

Notes

• Flash message is only shown when clicking Save and Next.
• Clicking Save only shows an in-line message:
  

Issues out of scope

• No confirmation when clicking Save or Save and Back to List on step 4 'Checkout options'.

Conclusion

This fixed the incorrect mapping of flash messages on the order cycle pages.
No regressions were found. Merging! 🎉

Thanks again! 🤗