Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11599-Change page title on checkout pages #11911

Conversation

arunguleria
Copy link
Contributor

What? Why?

What should we test?

  • As a: guest shopper or loggedin shopper
  • On page: checkout process
  • Previously Checkout pages have the same title for all steps(details, payment and summary ): Checkout - Open Food Network
  • Now Page title has changed for every step
  • URL ending with /checkout/details -> have page title Checkout Details - Open Food Network
  • URL ending with /checkout/payment -> have page title Checkout Payment - Open Food Network
  • URL ending with /checkout/summary -> have page title Checkout Summary - Open Food Network

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes

The title of the pull request will be included in the release notes.

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. That's a great solution. I will add another commit to demonstrate what I mean with my comments below.

spec/system/consumer/checkout/details_spec.rb Outdated Show resolved Hide resolved
spec/system/consumer/checkout/payment_spec.rb Outdated Show resolved Hide resolved
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍 Thanks !

@arunguleria arunguleria force-pushed the 11599-checkout-page-title-changes branch from 2abcc33 to 29ef444 Compare December 8, 2023 03:35
@drummer83 drummer83 self-assigned this Dec 10, 2023
@drummer83 drummer83 added the pr-staged-au staging.openfoodnetwork.org.au label Dec 10, 2023
@drummer83
Copy link
Contributor

Hi @arunguleria,
Thank you so much for working on this! 💪
I did some testing and I can confirm that

  • page titles for checkout steps now have individual strings,
  • the strings can be defined in the translation files,
  • the English default values are as expected:
    • Checkout Details - Open Food Network
    • Checkout Payment - Open Food Network
    • Checkout Summary - Open Food Network
  • this works for logged-in users as well as for guest users.

I couldn't spot any problems with this - excellent! Thank you again! 🥳
Merging! 🚀

@drummer83 drummer83 merged commit 5aaaef6 into openfoodfoundation:master Dec 10, 2023
52 checks passed
@drummer83 drummer83 removed the pr-staged-au staging.openfoodnetwork.org.au label Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Change page title on checkout pages
4 participants