Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show warning when a new invoice can be generated #11921

Merged
merged 5 commits into from
Jan 8, 2024
Merged

show warning when a new invoice can be generated #11921

merged 5 commits into from
Jan 8, 2024

Conversation

abdellani
Copy link
Member

@abdellani abdellani commented Dec 11, 2023 •
edited by RachL

What? Why?

What should we test?

  • enable invoice feature
  • access an order
  • edit the order
  • access the invoices page
  • you should see the warning again
  • click on "generate/update invoice"
  • the warning should disappear after the creation/update of the invoice.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

dacook
dacook approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is a draft so I'm not sure if this was ready to review. I looked anyway and have a suggestion for organising the translation keys (it would be great to organise it more because it's such a mammoth file!!)

config/locales/en.yml Outdated Show resolved Hide resolved
@abdellani abdellani force-pushed the 11431-show_warning_when_a_new_invoice_can_be_generated branch from afd2e37 to 1038536 Compare December 14, 2023 14:34
@abdellani abdellani marked this pull request as ready for review December 14, 2023 14:34
dacook and others added 3 commits December 15, 2023 09:55
@dacook
[fixup] Fix translation key
ad809fa 
The dot indicates lazy lookup
Also the name was missing a letter. It was hard to notice because the key name was so long, so I suggest reducing the key to something like 'order_has_changed'
@dacook
[suggestion] Update translation key
aebc378
@mkllnk
Partial spec of error message for readability
57a6d1e 
This avoids Rubocop warnings. We don't need to test for the whole
message. The tested part is unique already and quicker to read.
@RachL RachL added technical changes only These pull requests do not contain user facing changes and are grouped in release notes pr-staged-fr staging.coopcircuits.fr labels Jan 5, 2024
@RachL RachL self-assigned this Jan 8, 2024
@RachL
Copy link
Contributor

RachL commented Jan 8, 2024

LGTM :) thanks @abdellani merging!

@RachL RachL merged commit 16a091d into openfoodfoundation:master Jan 8, 2024
50 checks passed
@RachL RachL removed the pr-staged-fr staging.coopcircuits.fr label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacook dacook dacook approved these changes

@mkllnk mkllnk mkllnk approved these changes

Assignees

@RachL RachL

@abdellani abdellani

Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
OFN Delivery board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Invoices] When a new invoice can be generated, display a warning to users
4 participants
@abdellani @RachL @mkllnk @dacook