Replaces Stripe Stubs with VCR calls #11924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
filipefurtad0
added
the
technical changes only
Adds new VCR cassettes Keeps assertion on ActiverMerchant response Re-records cassettes
filipefurtad0
force-pushed
the
stripe_sca_vcr_spec
branch
from
0684204
to
b45fc0b
Compare
filipefurtad0
commented
Dec 11, 2023
|
I have to admit I don't know how to deal with the |
dacook
reviewed
Dec 12, 2023
Fixes typo on capture_amount declaration
filipefurtad0
force-pushed
the
stripe_sca_vcr_spec
branch
from
b259185
to
0f41d90
Compare
dacook
approved these changes
Dec 12, 2023
mkllnk
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces stubs on VCR cassettes. We do this here for the file
./spec/models/spree/gateway/stripe_sca_spec.rb.What? Why?
Instead of asserting on our DB we can callStripe::PaymentIntent.retrieveto actually be sure that the Stripe paymentchanges status, by running our code 馃帀-> rookie optimism :-)Edit:
we canwe'll just do the above and assert on the ActiveMerchant response...What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates