Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Dashboard header in the header area for multi-enterprise users #11927

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

drummer83
Copy link
Contributor

What? Why?

For multi-enterprise users the header 'Dashboard' on the dashboard page was shown below the header area and not inside of it. This should be fixed now.

Before:
image

After:
image

What should we test?

  • Make sure have multiple (at least two) enterprises.
  • Visit the overview page /admin.
  • Check the position of the header 'Dashboard'.
  • It should be inside the light blue header area (same vertical position as the link to the user guide).

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@drummer83 drummer83 self-assigned this Dec 11, 2023
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, thank you! I wonder why it was done that way in the first place..

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

@RachL RachL added the pr-staged-fr staging.coopcircuits.fr label Dec 18, 2023
@RachL
Copy link
Contributor

RachL commented Dec 18, 2023

Before :

image

image

After:

image

image

LGTM! merging :-)

@RachL RachL merged commit 2b74971 into openfoodfoundation:master Dec 18, 2023
52 checks passed
@RachL RachL removed the pr-staged-fr staging.coopcircuits.fr label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants