Bump rubocop from 1.58.0 to 1.59.0 #11933
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.58.0 to 1.59.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.58.0...v1.59.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
After regenerating the todo file, Rails/OutputSafety is still coming up.
They seem to be false positives though: It thinks that I did a git bisect to find the culprit and found it: @dacook Your rule is great but it overrides the todo file. Cop settings are stored in a hash and each key can be present once only. So |
|
Oh, how unfortunate. Maybe we could move my rule to the todo file? Hmm no, then when we regenerate it, it will replace the rule. Maybe we should fix all the Rails/OutputSafety todos? They're probably all valid uses, and just need a rubocop:disable comment. I can try after lunch if you like. |
The tag generator methods should already be returning html_safe strings.
These all seem to require html_safe/raw, so we'll permit it. Some of the spree code is a bit strange and could probably be improved, but I think it's ok for now.
This one is a little more concerning: what if a model error message includes the user-submitted value? But this is for the admin interface only, and I'm not sure if we have model error messages that do that. So it's probably fine (it's certainly been like this a long time already).
There was a problem hiding this comment.
Great work.
I keep wondering if some of these could have been written in a better way. But we don't need to add to our list at the moment.
And in the end, this now means that you are not allowed to add any violations of this cop to the todo list. You have to solve it or add a comment in the code. I'm happy with that.
Bumps rubocop from 1.58.0 to 1.59.0.
Release notes
Sourced from rubocop's releases.
Changelog
Sourced from rubocop's changelog.
Commits
e5a164aCut 1.592912b6eUpdate Changelog3bcc171[Fix #12524] Fix a false positive forStyle/MethodCallWithArgsParentheses0daa4aaMakeStyle/MethodCallWithoutArgsParenthesesallow parenthesizeditb240a09MakeStyle/RedundantSelfallowself.ita0e1042[Fix #12526] Fix incorrect rendering typosb1bcb31[Fix #12444] Fix false positive forStyle/HashEachMethods3b0360bAdd newLint/ItWithoutArgumentsInBlockcop4e9cfccMerge pull request #12521 from koic/make_style_select_by_regexp_aware_of_safe...037c860Merge pull request #12438 from koic/fix_a_false_positive_for_lint_literal_ass...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)