Replaces Stripe stubs with the real account IDs #11950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipefurtad0
force-pushed
the
stripe_accounts_vcr_spec
branch
from
ea062e6
to
e164d93
Compare
filipefurtad0
force-pushed
the
stripe_accounts_vcr_spec
branch
from
1997f85
to
159af3b
Compare
filipefurtad0
changed the title
filipefurtad0
commented
Dec 19, 2023
| end | ||
| end | ||
|
|
||
| context "when the Stripe API disconnect succeeds" do | ||
| before { Stripe.client_id = client_id } | ||
|
|
||
| it "destroys the record" do | ||
| # returns status 200 |
There was a problem hiding this comment.
On this example I'm getting status 401 as well:
(Bugsnag).notify(#<RuntimeError: StripeDeauthorizeFailure>, {:enterprise_id=>177, :stripe_account=>"acct_1FiqEsKuuB1fWySn"})
expected: 0 times with any arguments
received: 1 time with arguments: (#<RuntimeError: StripeDeauthorizeFailure>, {:enterprise_id=>177, :stripe_account=>"acct_1FiqEsKuuB1fWySn"})
Not sure why this is happening. To be continued...
There was a problem hiding this comment.
The issue here is that apparently, stripe_account is not connected:
{
"error": "invalid_client",
"error_description": "This application is not connected to stripe account <HIDDEN_ACCOUNT>, or that account does not exist."
}
So, it does no pass the disconnect test. This is the case, even if use create_account from lib/stripe/account_connector.rb... Maybe I should test this file before proceeding here.
There was a problem hiding this comment.
Ok, got it now - we can actually create a simple account with a direct API call to Stripe, and then pass it as an argument to our deauthorize_and_destroy method defined here.
If we do this, then the account can be disconnected and Bugsnag is not triggered.
Adds STRIPE_ACCOUNT as sensitive data to VCR setup Rubocop fixes and re-recording of cassettes Adds bogus client_id to local test file - for CI to run
filipefurtad0
force-pushed
the
stripe_accounts_vcr_spec
branch
from
586a553
to
8f003c3
Compare
filipefurtad0
changed the title
Re-records cassettes Creates a bogus publishable key We need to feed some value to the ENV variables which are picked up from the local test environment, for the build to run. We could also store them all as environment secrets on our repo, but I don'r think this is necessary, as we only run recorderd API/VCR calls on our build, and never real API calls.
filipefurtad0
force-pushed
the
stripe_accounts_vcr_spec
branch
from
8f003c3
to
d8d874f
Compare
filipefurtad0
added
the
technical changes only
mkllnk
approved these changes
Dec 21, 2023
Comment on lines
+29
to
+33
| expect { | ||
| stripe_account.deauthorize_and_destroy | ||
| }.to change( | ||
| StripeAccount.where(stripe_user_id:), :count | ||
| ).from(1).to(0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Related to Epic #11890.
Closes #11949.
Sets up the spec with Stripe credentials, so our code can actually make the real calls to Stripe; Records responses.
Also adds STRIPE_ACCOUNT as sensitive data to VCR setup.
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates