Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full product and variant name on DFC API #11956

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Dec 20, 2023

What? Why?

What should we test?

  • No test here.
  • Production test within the Regenerative Produce group.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@mkllnk mkllnk self-assigned this Dec 20, 2023
@mkllnk mkllnk marked this pull request as ready for review December 20, 2023 05:45
@mkllnk mkllnk added the api changes These pull requests change the API and can break integrations label Dec 20, 2023
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too easy !

@mkllnk
Copy link
Member Author

mkllnk commented Jan 3, 2024

Hm, David didn't review this one and is back on holiday. We want to test this in production soon. So I'll merge this for the next release.

@mkllnk mkllnk merged commit 9909841 into openfoodfoundation:master Jan 3, 2024
52 checks passed
@mkllnk mkllnk deleted the dfc-product-name branch January 3, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api changes These pull requests change the API and can break integrations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Serve full product name on DFC API
2 participants