Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Punjabi and Malayalam language for India instance #11855 #11957

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

duleorlovic
Copy link
Contributor

What? Why?

What should we test?

  • Add AVAILABLE_LOCALES="en_IN,ml,pa" to .env file
  • Click on globe icon in top navbar
  • Select Malayalam or Punjabi language from dropdown

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@duleorlovic
Copy link
Contributor Author

I noticed that on pa.yml the keys are not recent (for example I can not find home_shop:) Probably someone need to update the keys on transiflex, not sure who is doing that ?
Should we copy en_IN.yml to pa.yml ?

@sigmundpetersen
Copy link
Contributor

Yes you can see on Transifex that these locales is not translated fully:
image

Keys will be added when they are translated and deployed to the instance the week after.

@duleorlovic
Copy link
Contributor Author

OK, Please merge so we can continue with translations...

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mkllnk mkllnk merged commit 589ae4d into openfoodfoundation:master Dec 20, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add locales for India instance
3 participants