Adds missing keys from i18n tasks output

[filipefurtad0]

What? Why?

Related to #11938.

The output from i18n-tasks missing has been added to this PR - it will be deleted on the last commit once all the entries have been verified. The idea is to check all of them and either ignore (if the key is found on en.yml - this seems to happen for dynamic keys) or add it to en.yml it it is indeed verified to be missing. In some case, the view file has been deleted, this is the case for:

• partial delete on app/views/devise/shared/_links.html.erb Remove unused Devise login links partial #12298
• app/views/checkout/payment/_gateway.html.haml (commit in this PR)
• app/views/home/_connect.html.haml (commit in this PR)
• app/views/home/_learn.html.haml (commit in this PR)

What should we test?

The scope is missing translations, so ideally, a quick test in using en.yml and a second locale should be done for the following pages, which should render well:

1. /admin/stripe_connect_settings/edit -> Instance Publishable Key
   

2. verify that translations work as before on all pages, during customer checkout
   I've removed this file, I don't think it is used:

3. As superadmin, check taxonomy pages, namely editing and creating new taxonomies. Can you find a remove button? Is it rendering correctly?

4. As a customer, initiate the checkout process, by adding some items to the cart. Edit the cart. Is the Continue shopping button displayed correctly, as before?

5. As admin, edit an order without any payments. Are you able to see any message stating that "the order has no payments"? I believe this was never the case. In summary: going through the side tabs, when editing an order as admin, should display all information correctly.

6. Ideally, we would trigger the flash message: "The order could not be updated" but I don't know how to trigger this. Will ask testers and update instructions.

7. As superadmin, editing states pages should display correctly

8. As superadmin, under /admin/contents/edit, verify that it is possible to enable/disable the Menu 6 icon name and Menu 7 icon name sections of the homepage.

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

[filipefurtad0]

Another option could have been to reuse the key thanks: "Thank you for your business.".

[filipefurtad0]

I'm not sure these keys are needed... But they are indeed missing.

[mkllnk]

Great pull request! Easy to follow, step by step.

And nice cleanup along the way. 😍

[filipefurtad0]

I've noticed there were these two files (which I've marked as needing issues to fix missing translations):

• app/views/home/_connect.html.haml
• app/views/home/_learn.html.haml

However, after a second look, I'm convinced they are not in use, so I've removed them still within this PR. Re-requesting review 🙏

[rioug]

Nice one ! Thanks for that 🙏 , it seems like an unpleasant task.

[mkllnk]

I'm convinced they are not in use, so I've removed them still within this PR.

Thank you! I forgot to remove them in a712f25.

[RachL]

@filipefurtad0 will this PR close #2626 ?

[filipefurtad0]

will this PR close #2626 ?

Hey @RachL ,
Not exactly. This PR uses a gem to locally look for missing translations and fixes / removes some unnecessary files.

I'd say the actual PR contributing to #2626 is #11906, as per this comment.

I'm not sure we should keep it open though as we've improved the previous code to detect more types of missing translations, and because we've opted not to implement any of the follow-up suggestions (references, comment above and here) like:

• integrating a build node to check the build
• and a Bugsnag warning to spot missing translations in production;

So, I'd say yes, let's close!

[filipefurtad0]

Hi @drummer83 , thanks for testing this one!

There are cases in which indeed, I don't know how to trigger the respective behavior. Some of them looked like dead code, so I've removed them in this PR. In other cases, I had no basis to assume that, and I felt it is better to add a key, then being to thorough on the grooming, which could actually create missing translations... Adding a key should not have any negative impact on the functionality of the app; worst case scenario, it's adding a key which is never rendered in the frontend. I don't see this as a big risk, so I've added keys on points

• 3
• 6 -> flash message commit is here f130470

On 4:

You replaced the old string 'your_cart_is empty' with the new one, but at the same time you added it as missing translation to en.yml line 265. I think it's not needed then anymore?

Good point. I guess this was my initial intention but left the key there, hanging. Done here. Thanks for spotting it!

As superadmin, under /admin/contents/edit, verify that it is possible to enable/disable the Menu 6 icon name and Menu 7 icon name sections of the homepage. ➡️ ✔️ Yes, this is working. But which part of the PR is affecting it?

None, the PR should not affect the pages. However, some files were removed, which could affect the page, but are not supposed to. This is the commit.

NB: The string 'taxon_edit' is used as page title only on a subpage of a page which uses 'taxonomy_edit' as page title. I think we could combine both of them in the existing 'taxonomy_edit'?

Nice catch! Done on the latest commit bfd4b73.

I think I've addressed everything. There are two new minor commits so I'm moving to code review.

Thanks again @drummer83 🙏

[drummer83]

Thanks, @filipefurtad0, for clarifying and updating the last bits!

I have tested the changes of your latest commits.
It's all looking good! 🎉
Merging! 🚀
Thanks again!

[dacook]

@filipefurtad0 Can you please confirm if this PR contained user-facing changes or not? I quickly scanned and couldn't see any evidence, but could be wrong.

[filipefurtad0]

Hey @dacook,
I've marked it as user facing as it introduces some new translation keys, on en.yml. I've checked previous releases, I think this is the current process. What do you think?

[dacook]

Sorry I missed that, yes that sounds good 👍