Send semantic id when connecting enterprise to app #11959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkllnk
added
the
api changes
It allows us to list enterprises from any OFN server, not just ofn-au. The app could even accept any enterprise on any server providing its data in the DFC format.
mkllnk
force-pushed
the
connect-app-id
branch
from
249259c
to
1903747
Compare
mkllnk
added
no-staging-FR
rioug
approved these changes
Dec 22, 2023
| subject.perform_now | ||
|
|
||
| expect(app.data).to eq({ "link" => "https://example.net/edit" }) | ||
| request = a_request(:post, url).with( |
mkllnk
removed
the
no-staging-AU
|
Hm, David didn't review this one and is back on holiday. We want to test this in production soon. So I'll merge this for the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Follow up from:
I realised that we can't test this functionality in staging while our Discover app is hardcoded to au-prod. We can open this up by providing the full URL to the enterprise data.
It allows us to list enterprises from any OFN server, not just ofn-au. The app could even accept any enterprise on any server providing its data in the DFC format.
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates