Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu and sub menu highlighting #11966

Merged

Conversation

bouaik
Copy link
Contributor

@bouaik bouaik commented Dec 21, 2023

What? Why?

What should we test?

  • In admin v3, check that the menu and sub menu are highlighted correctly

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you.

Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍 Thanks for your help !

@drummer83 drummer83 self-assigned this Dec 22, 2023
@drummer83 drummer83 added pr-staged-uk staging.openfoodnetwork.org.uk pr-staged-au staging.openfoodnetwork.org.au and removed pr-staged-uk staging.openfoodnetwork.org.uk labels Dec 22, 2023
@drummer83
Copy link
Contributor

Hi @bouaik,
Thank you for this great contribution! 💪

I can confirm that the Products and Inventory pages now have the correct menu highlighting:
image

image

I couldn't check the Roles page because it wouldn't load on our staging servers due to a timeout error (I opened #11976). Probably there is just too much data to be displayed in that case. However, that page is only for super admins and not critical, so we can go untested with that one.

Bottom line: It's working great! I couldn't spot any regressions or issue with your PR. Excellent!
It's ready to get merged! 🎉
Thanks again! 🚀

@drummer83 drummer83 merged commit eb70eb4 into openfoodfoundation:master Dec 22, 2023
54 checks passed
@drummer83 drummer83 removed the pr-staged-au staging.openfoodnetwork.org.au label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

When on Product, Inventory or Users pages, menu is not highlighted correctly
4 participants