Moves test introduced by #11799 to avoid non-explicit modal acceptance #11972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… spec where a modal does not need acceptance Tests forward navigation
filipefurtad0
added
the
technical changes only
mkllnk
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
On #11799 a fix was introduced to account for "memory" of the selected sections, within the enterprise dashboard. A test was added which was triggering a modal (due to unsaved changes in the forms), without explicitly accepting it.
While default acceptance of the modal is the usual behavior, it often timed out, while running in the CI.
The PR moves the test to a section in the spec where there are no unsaved changes: doing so prevents having to accept the modal.
The PR also adds some minor changes (scrolling down the page to find the Users section - somehow failing locally) and adds a test to account for forward navigation as well.
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates